Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Theme support #44840

Closed
smith opened this issue Sep 5, 2019 · 2 comments
Closed

[APM] Theme support #44840

smith opened this issue Sep 5, 2019 · 2 comments
Labels
Team:APM All issues that need APM UI Team support

Comments

@smith
Copy link
Contributor

smith commented Sep 5, 2019

All theme usage in APM is imported from '@elastic/eui/dist/eui_theme_light.json'.

We should be taking the user's theme preference into account and applying the theme consistently throughout the plugin.
@smith smith added the Team:APM All issues that need APM UI Team support label Sep 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv
Copy link
Member

@smith Thanks for creating this.

We already have issues for dark mode here:
#29725
#30048

You okay with me closing this?

@smith smith closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smith @sorenlouv @elasticmachine