Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Embeddables filtered by timepicker ignore the field given by the timepicker #44138

Closed
stacey-gammon opened this issue Aug 27, 2019 · 5 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience discuss Feature:Canvas Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Aug 27, 2019

Maybe not exactly a bug but the behavior isn't clear.

The canvas time picker has a time field, but for embeddables this is being transformed to the timeRange input, not used as a filter, and this will filter on whatever field is marked at the "time" field when the index pattern object was created. This is why in #44129, near the end the data showing up in the two searches is different. One is being filtered on @timestamp one on timestamp field.

So if your data has multiple time fields, and you pick one that is not the default from the index pattern being used by the embeddable, would the user expect it to filter on the field you explicitly chose for the time picker, or the default one? Right now it filters on the default one, but I think that would be unexpected from a user perspective because they explicitly choose the field.

Not sure how to resolve that though or what the right experience is. 🤔

@stacey-gammon stacey-gammon added bug Fixes for quality problems that affect the customer experience discuss Feature:Embedding Embedding content via iFrame Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Aug 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@stacey-gammon
Copy link
Contributor Author

Tagging App arch too, I think it would be interesting to discuss passing down time range as a filter and getting rid of the specific timeRange input. That would make this easier, and I think is a better long term plan since we want to get rid of reliance on index pattern objects.

@streamich streamich self-assigned this Dec 2, 2019
@streamich streamich removed the v7.4.0 label Dec 2, 2019
@streamich streamich removed their assignment Dec 4, 2019
@Dosant Dosant added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort triaged labels Jun 12, 2020
@clintandrewhall
Copy link
Contributor

We'll be working on this with an update to filtering between dashboards and canvas.

selfie-0
GitHub Selfies

@crob611
Copy link
Contributor

crob611 commented Apr 23, 2021

Closing this issue as we don't strip the field off the time filters anymore. There is still some confusion around an embeddable having a time range, and also being able to use a time filter with a field, but we will track that in the overall filtering in canvas issue #88709

@crob611 crob611 closed this as completed Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience discuss Feature:Canvas Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants