-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPM] Use NP server route handler #43269
Comments
Pinging @elastic/infra-logs-ui |
Did a quick POC in jfsiii@6aab980 (see commit message for more info) |
@jfsiii are you still investigating? What does the |
@sgrodzicki No, I'm not investigating it. I didn't know how to classify it since it's neither |
Back to backlog sounds reasonable. Thanks for the clarification! |
@jfsiii With the recent changes and merge to master, can this be closed? |
@ruflin yes. Just closed it |
Edit: Don't work on this until
#44170 #44174server.route
from #44620, and #44143 is resolvedSwap
hapi
implementation out for NP. Letters added to make it easy to refer to, not because the order matters.A: Update the way route handlers are added
[Discuss] Add NP core.http.route #44174Introduce HttpApi and HttpResource services #44620B: Update the way routes are validated NP Router handler doesn't provide to request body on validate: false #44170 (comment)
C: Change handlers to get Elasticsearch and Saved Object clients from
context
D: Change the signature for handlers (
(req, context)
=>(context, req, res)
)E: Handle response status, headers (
response.notFound
,response.ok
, etc)From #41894
A: Avoid
router.get
,router.post
, etc. in favor ofserver.route
coming as part of #44620B: We don't do
options.query
oroptions.params
right now, but will need to update (remove) types in handlers and switch to@kbn/config-schema
-based approach.C:
elasticsearch
is available now undercontext.core.elasticsearch
. @rudolf is [currently migrating the Saved Objects client](ES is ready. SO PR is #44143) and will also expose them undercontext.core
.D: related to B Blocked on C (getting ES & SO from
context
)The text was updated successfully, but these errors were encountered: