[APM] Persist local UI filters across views

[dgieselaar]

If a local UI filter is selected in one view, and the user navigates to another view that has that filter as well, the filter value should persist. E.g. when the user has selected the host in the services list, and clicks on the traces tab, the host filter should be carried over into the traces view. This is useful for the user when they're investigating certain components, e.g. how a specific host is performing.

[elasticmachine]

Pinging @elastic/apm-ui

[sorenlouv]

Could this be solve by adding local filters to the list of PERSISTENT_APM_PARAMS:

kibana/x-pack/legacy/plugins/apm/public/components/shared/Links/apm/APMLink.tsx

Lines 21 to 29 in 4a1f41e

	export const PERSISTENT_APM_PARAMS = [
	'kuery',
	'rangeFrom',
	'rangeTo',
	'refreshPaused',
	'refreshInterval',
	'environment'
	];

Or perhaps even better: overhauling our links and explicitly pass the params that should be carried over?
Might want to take a look at the History Tabs which have their own logic for this (which they probably shouldn't have):

kibana/x-pack/legacy/plugins/apm/public/components/shared/HistoryTabs/index.tsx

Lines 42 to 48 in 4a1f41e

	const searchWithoutTableParameters = omit(
	toQuery(location.search),
	'sortField',
	'sortDirection',
	'page',
	'pageSize'
	);

[dgieselaar]

Here's a list of links that need to be updated. I've included the breadcrumbs for now, but we could also drop those for an initial implementation if they're hard to get right.

- Service Overview => Transaction Overview (table)
- Service Overview => Trace Overview (tab)

- Trace Overview => Transaction Detail (table)
- Trace Overview => Service Overview (tab)
- Trace Overview => Service Overview (breadcrumb)

- Transaction Overview => Transaction Detail (table)
- Transaction Overview => Error Overview (tab)
- Transaction Overview => Metrics Overview (tab)
- Transaction Overview => Service Overview (breadcrumb)

- Error Overview => Transaction Overview (tab)
- Error Overview => Metrics Overview (tab)
- Error Overview => Transaction Overview (breadcrumb)
- Error Overview => Service Overview (breadcrumb)

- Metrics Overview => Transaction Overview (tab)
- Metrics Overview => Error Overview (tab)
- Metrics Overview => Transaction Overview (breadcrumb)
- Metrics Overview => Service Overview (breadcrumb)

- Transaction Detail => Transaction Overview (breadcrumb)
- Transaction Detail => Transaction Overview (flyout)
- Transaction Detail => Trace Overview (full trace link)

[dgieselaar]

To answer your question:

Could this be solve by adding local filters to the list of PERSISTENT_APM_PARAMS:

I don't think so, we need to know which local UI filters are supported by the page we are linking to, otherwise filters will be applied without a UI to make them visible to the user.

[sorenlouv]

I don't think so, we need to know which local UI filters are supported by the page we are linking to, otherwise filters will be applied without a UI to make them visible to the user.

Makes sense. So the simpler solution is to add them manually to the links as needed. Or what do you think?

[dgieselaar]

@sqren I think having components like <TransactionOverviewLink/> would be a good idea as you proposed earlier. I'll open a draft PR that implements it for a couple of links in a bit to get some early feedback.

[dgieselaar]

Closed in #43988.