Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Show indication in LayerTOC that apply-global-filter is turned off #42972

Closed
thomasneirynck opened this issue Aug 8, 2019 · 2 comments · Fixed by #43283
Closed

[Maps] Show indication in LayerTOC that apply-global-filter is turned off #42972

thomasneirynck opened this issue Aug 8, 2019 · 2 comments · Fixed by #43283
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement

Comments

@thomasneirynck
Copy link
Contributor

The layer TOC should indicate that global filters are not being applied when there are global filters specified for that index-pattern.

The mechanism could be similar to how the TOC shows an info-tooltip when the layer is showing incomplete query-results (#40805)

@thomasneirynck thomasneirynck added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Aug 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@thomasneirynck thomasneirynck changed the title [Maps] provide indication in LayerTOC that apply-global-filter is turned off [Maps] Show indication in LayerTOC that apply-global-filter is turned off Aug 8, 2019
@nreese
Copy link
Contributor

nreese commented Aug 9, 2019

@thomasneirynck

What about layers that do not fetch data from Elasticsearch sources and are never affected by the global filter bar and query context?

I think only showing an icon next to layers with disabled global filters ES sources will not signal to users that non-ES layers are also not effected by the global query context.

What about doing the inverse and putting the eui fitler icon next to any layer that is effected by the global query context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants