Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StorageService + add linter rule to prevent raw access #41982

Open
joshdover opened this issue Jul 25, 2019 · 2 comments
Open

Add StorageService + add linter rule to prevent raw access #41982

joshdover opened this issue Jul 25, 2019 · 2 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Add a StorageService that plugins can use to interact with localStorage and sessionStorage.

This service should prefix all keys with the plugin's ID to make ensure that plugins cannot overwrite or access keys from other plugins.
@joshdover joshdover self-assigned this Jul 25, 2019
@joshdover joshdover added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover joshdover removed their assignment Sep 19, 2019
@pgayvallet pgayvallet mentioned this issue Oct 29, 2019
Merged
7 tasks
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
@mshustov mshustov reopened this Feb 23, 2022
@botelastic botelastic bot removed the stale Used to mark issues that were closed for being stale label Feb 23, 2022
@mshustov
Copy link
Contributor

I reopened the issue. We had many complaints about runtime errors when the write operation failed since LocalStorage was full. A core abstraction could handle this problem gracefully: write, catch an error, remove obsolete/unnecessary large entires, retry write operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshdover @mshustov @elasticmachine