Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flot with Elastic Charts in Canvas #41714

Closed
timductive opened this issue Jul 22, 2019 · 7 comments
Closed

Replace flot with Elastic Charts in Canvas #41714

timductive opened this issue Jul 22, 2019 · 7 comments
Labels
Feature:Canvas Feature:ElasticCharts Issues related to the elastic-charts library impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@timductive
Copy link
Member

Currently, Canvas uses flot.js under the hood to power chart visualizations. We should instead use Elastic Charts.

@timductive timductive added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@timroes
Copy link
Contributor

timroes commented Jul 23, 2019

cc @markov00

@shaunmcgough
Copy link

Are we sure we want to replace flot entirely, or do we want to just add Elastic Charts first, and then replace flot? I think it would make more sense to do two PRs for this issue. What is your thinking, @timductive and @clintandrewhall and @elastic/kibana-canvas?

@timductive
Copy link
Member Author

@shaunmcgough Whenever we get to this work I think whomever picks it up should make that call.

@shaunmcgough
Copy link

Thanks, @timductive that makes a lot of sense.

@timductive timductive added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 24, 2019
@shaunmcgough
Copy link

@poffdeluxe what do you think about my comment from Sep 27, out of curiosity?

@poffdeluxe
Copy link
Contributor

Since we are putting this project on hold in favor of putting Lens in Canvas, I wanted to drop my notes so far regarding my exploration of Elastic Charts: https://docs.google.com/document/d/1rti_ob-2erHO51plpvbSMrQgsB1fmQNx3JMpiU0UiXg/edit?usp=sharing

I made a branch that added a useFlot var to the plot function to let me mess around with Elastic Charts: master...poffdeluxe:poff/wip-plotting
This branch is nowhere close to production ready and needs some major clean-up

@shaunmcgough apologies for the delayed reply (just now seeing this) but yeah, I think there would absolutely have to be a transition period where people would have to opt-in to use Elastic Charts and then at some point, we would make it the default with an escape hatch to use flot

@markov00 markov00 added the Feature:ElasticCharts Issues related to the elastic-charts library label Jan 23, 2020
@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas Feature:ElasticCharts Issues related to the elastic-charts library impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

7 participants