Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Update route names #40995

Closed
sorenlouv opened this issue Jul 12, 2019 · 3 comments · Fixed by #41233
Closed

[APM] Update route names #40995

sorenlouv opened this issue Jul 12, 2019 · 3 comments · Fixed by #41233
Labels
Team:APM All issues that need APM UI Team support v7.4.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Jul 12, 2019 •
edited by zube bot
Loading

Closes #40370

To prepare for local filters we need to do some route changes, and while we are breaking the url we might as well fix some long standing issues:

  • Remove transaction type from path and replace it with a local filter
  • Remove transaction name from path and replace with query param
  • append "/services" to applicable routes to avoid route clashes (APM URL paths #40370)
  • Remove legacyDecodeURIComponent and legacyEncodeURIComponent since they are no longer needed
@sorenlouv sorenlouv added [zube]: In Progress Team:APM All issues that need APM UI Team support v7.4.0 labels Jul 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@dgieselaar
Copy link
Member

Is this a breaking change? given that the URLs will dramatically change.

@formgeist
Copy link
Contributor

Depends, will we try and convert an old URL and redirect or will the pages just stop working?

@sorenlouv sorenlouv mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:APM All issues that need APM UI Team support v7.4.0
Projects
None yet
Milestone
No milestone
4 participants
@sorenlouv @dgieselaar @formgeist @elasticmachine