-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime APM UI index configuration #39741
Comments
Pinging @elastic/apm-ui |
fyi @tbragin |
@elastic/apm-ui Could use some help understanding the implications of configuring the default indices in this way. What would need to happen for us to be able to support it? I'm currently considering where these settings might sit within Kibana, and will also be investigating how users might be able to configure these settings per space in Kibana. |
@graphaelli @formgeist We could start with Kibana Advanced Settings, and not make these space-specific? Similar to the following SIEM setting. Alternative would be to put this into the APM app itself, like we did with the Logs and Infra UI source configuration. I believe these settings are space-specific. @roncohen @alvarolobato What do we currently default to when selecting whether to make new functionality we build in Observability apps Kibana Space aware or not? cc @nehaduggal |
As I understand this proposal the default settings should still come from kibana.yml but be changable at runtime? So if Kibana is restarted it will go back to kibana.yml settings? Or will the runtime changes be persisted somewhere? Perhaps this overriding behaviour should be generic and built-in to Kibana. So any setting specified in kibana.yml can be changed at runtime, and not only specific APM settings. |
Yes, at least initially for backwards compatibility in 7.x.
I didn't originally dive into the implementation details but a look at infra-ui shows it stores the configuration as a saved object per space - |
@katrin-freihofner We have decided to move forward with this so I've moved it to the design board. There are probably other higher priority items so just whenever it makes sense for you to look into. |
If we decide for a per app settings page this could be solved by: #40236 |
@sqren sorry for the confusion. This is what I'm working on in the header issue: If we want a settings page per app, we could navigate to it by one of the links/tabs in this header. |
I'm not sure what exactly is needed from a design perspective to get this going? |
Currently the link to "Settings" takes the user to the agent configuration page. This issue is about creating a page where the user can configure which indices to use for apm (eg. Kibana has an "Advanced Settings Page": Should it look like that? LMK if you want to zoom about this. |
As discussed via zoom with @sqren we need an APM specific settings page where the following can be configured:
|
@katrin-freihofner Sounds good 👍 |
Since all the fields in "UI settings" are for indicies, we might call it "Index settings" instead. |
Should we additionally provide a |
This would just clear all fields, right? So I'm not sure how useful that'll be. |
Yes. I guess it is fine for now - if we get more and more settings it might be helpful. |
Makes sense to avoid "settings". |
Design update:
@bmorelli25 could you please help me with the intro text on the top and the hints under each input field - I'm pretty sure we can do better than my mockup shows ;) |
Here's a starting point for a discussion on the intro text and input hints. @katrin-freihofner
|
Thanks @bmorelli25. Building on top of that I'll also have a go:
Suggestion
|
Nice, thanks @sqren! Can we just remove the bolded "source map indices", "error indices", etc., since they match the text above the input? We could also mention kibana.yml and link to the documentation page. Something like this might work (where The APM UI uses index patterns to query your APM indices. If you've customized the index names that APM Server writes events to, you may need to update these patterns for the APM UI to work. Settings here take precedence over those set in Source map indices Error indices etc. |
Good idea with link to kibana.yml docs 👍 It's a wrap from here. |
@katrin-freihofner LGTM 👍 One thing: when we read the value from kibana.yml it's not possible to see if it's set or not because there is a default value if it's not set ( |
Ok, thank you! |
Describe the feature:
The APM UI currently relies on kibana.yml settings for configuration of indices to use for APM data. This is a request to allow configuration after kibana has started, similar to what is available for the logs and infra uis.
We may also consider making this space-specific, so that different spaces can be set up to use different APM indices. That may simplify future work regarding spaces for the APM UI.
The text was updated successfully, but these errors were encountered: