Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra/Logs UI] Turn source configuration into a tab #39071

Closed
weltenwort opened this issue Jun 17, 2019 · 14 comments
Closed

[Infra/Logs UI] Turn source configuration into a tab #39071

weltenwort opened this issue Jun 17, 2019 · 14 comments
Assignees
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature loe:large Large Level of Effort needs design Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Jun 17, 2019

Summary

The source configuration, which is currently shown in a flyout in the Infra UI and the Logs UI, should instead be shown as a tab in the top-level tabbed navigation. In order to avoid having two levels of tabs, the sections and tabs of the current flyout could be turned into sections akin to the sections on Kibana's advanced settings page.

For the Logs UI this means introducing the tabbed navigation in the first place.

Rationale

The addition of new features will lead to the creation of additional full-screen views as well as new settings. A top-level tabbed navigation is already established in APM and the Infra UI to navigate between such full-screen views. Turning the settings flyout into a tab also frees up space on the Infra UI and Logs UI toolbars.

Acceptance criteria

  • The Infra UI has a "Settings" tab as the rightmost tab, that contains the source configuration form.
  • The Logs UI has a tab bar at the top similar to the Infra UI.
  • The first Logs UI tab is a "Stream" tab, that contains the current logs page content.
  • The rightmost Logs UI tab is a "Settings" tab, that contains the source configuration form.
  • The active tab is represented in the URL (similar to how it's already done in the Infra UI).
  • The buttons and links to the source configuration flyout are removed from both the Infra UI and the Logs UI.

Mockups

grafik

grafik

grafik

@weltenwort weltenwort added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.3.0 v8.0.0 labels Jun 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@jasonrhodes
Copy link
Member

jasonrhodes commented Jun 17, 2019

Tabs as navigation is kind of a growing scourge in Kibana-land, but this is the pattern emerging so it makes sense to follow with that for now. SIEM has created a slightly stylized version of tabs that we should look into.

Screen Shot 2019-06-12 at 11 53 54 AM cropped

@weltenwort
Copy link
Member Author

I agree... design support on this would be highly appreciated. (@hbharding 😉)

@Zacqary Zacqary self-assigned this Jun 18, 2019
@Zacqary
Copy link
Contributor

Zacqary commented Jun 18, 2019

To confirm, this isn't just changing the "Configuration" button to a tab, this is also placing the settings form inside the page content instead of in a side flyout?

@jasonrhodes
Copy link
Member

To confirm, this isn't just changing the "Configuration" button to a tab, this is also placing the settings form inside the page content instead of in a side flyout?

Right, it would move out of the flyout. I think we may need to consider if we still want to do this with the ML integration work in a bit of scope-limbo... I'll ping you to chat.

@hbharding
Copy link
Contributor

I like this! +1 to a consistent UX. However, as a newcomer, take my endorsement with a grain of salt :). I want to make sure there are no major downstream implications that we need to look out for. For instance, @jasonrhodes has mentioned nested tabs can be problematic – i'd like to dig into that to understand why.

@jasonrhodes
Copy link
Member

jasonrhodes commented Jun 24, 2019

Moving this back to the backlog for now until we sort out a little more of the ML integration work. This work isn't directly related to the ML integration and we may want to do this regardless, but we should think about it with @hbharding and decide the best way forward.

@jasonrhodes jasonrhodes added [zube]: Inbox needs design Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature and removed [zube]: Ready v7.3.0 Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services needs design v8.0.0 labels Jun 24, 2019
@Kerry350
Copy link
Contributor

Kerry350 commented Aug 6, 2019

Closed with #42243

@Kerry350 Kerry350 closed this as completed Aug 6, 2019
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Aug 6, 2019
@zube zube bot reopened this Aug 6, 2019
@zube zube bot added [zube]: Ready and removed [zube]: Done labels Aug 6, 2019
@zube zube bot closed this as completed Aug 6, 2019
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Aug 6, 2019
@zube zube bot reopened this Aug 6, 2019
@zube zube bot added [zube]: Ready and removed [zube]: Done labels Aug 6, 2019
@zube zube bot closed this as completed Aug 6, 2019
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Aug 6, 2019
@zube zube bot reopened this Aug 6, 2019
@zube zube bot added [zube]: Ready and removed [zube]: Done labels Aug 6, 2019
@zube zube bot closed this as completed Aug 6, 2019
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Aug 6, 2019
@zube zube bot reopened this Aug 6, 2019
@zube zube bot added [zube]: Ready and removed [zube]: Done labels Aug 6, 2019
@Kerry350
Copy link
Contributor

Kerry350 commented Aug 6, 2019

🙄🙄🙄🙄🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature loe:large Large Level of Effort needs design Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

9 participants