-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra/Logs UI] Turn source configuration into a tab #39071
Comments
Pinging @elastic/infra-logs-ui |
I agree... design support on this would be highly appreciated. (@hbharding 😉) |
To confirm, this isn't just changing the "Configuration" button to a tab, this is also placing the settings form inside the page content instead of in a side flyout? |
Right, it would move out of the flyout. I think we may need to consider if we still want to do this with the ML integration work in a bit of scope-limbo... I'll ping you to chat. |
I like this! +1 to a consistent UX. However, as a newcomer, take my endorsement with a grain of salt :). I want to make sure there are no major downstream implications that we need to look out for. For instance, @jasonrhodes has mentioned nested tabs can be problematic – i'd like to dig into that to understand why. |
Moving this back to the backlog for now until we sort out a little more of the ML integration work. This work isn't directly related to the ML integration and we may want to do this regardless, but we should think about it with @hbharding and decide the best way forward. |
Closed with #42243 |
🙄🙄🙄🙄🙄 |
Summary
The source configuration, which is currently shown in a flyout in the Infra UI and the Logs UI, should instead be shown as a tab in the top-level tabbed navigation. In order to avoid having two levels of tabs, the sections and tabs of the current flyout could be turned into sections akin to the sections on Kibana's advanced settings page.
For the Logs UI this means introducing the tabbed navigation in the first place.
Rationale
The addition of new features will lead to the creation of additional full-screen views as well as new settings. A top-level tabbed navigation is already established in APM and the Infra UI to navigate between such full-screen views. Turning the settings flyout into a tab also frees up space on the Infra UI and Logs UI toolbars.
Acceptance criteria
Mockups
The text was updated successfully, but these errors were encountered: