Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] Concatenate plugin CSS files #38044

Closed
jen-huang opened this issue Jun 4, 2019 · 4 comments
Closed

[DISCUSS] Concatenate plugin CSS files #38044

jen-huang opened this issue Jun 4, 2019 · 4 comments
Labels
discuss Team:Operations Team label for Operations Team

Comments

@jen-huang
Copy link
Contributor

Describe the feature:

In the built version of Kibana, about 30 or so plugin CSS files are generated in /built_assets/css/plugins. Can we reduce this number by concatenating all these files into one large file?

Describe a specific use case for the feature:

In users' production environment, these CSS files translate to 30 or so separate outgoing requests that contribute to a high initial load time since browsers have a maximum connections limit.

@jen-huang jen-huang added discuss Team:Operations Team label for Operations Team labels Jun 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@jbudz
Copy link
Member

jbudz commented Jun 4, 2019

+1, not sure where it stands with complexity involved. a further improvement may be to bundle css by application to keep file size down.

@spalger
Copy link
Contributor

spalger commented Jun 17, 2019

Well, we could do a lot to reduce the number of style sheets by just removing the uiExports.styleSheetPaths from different plugins and importing them all from a single central .scss file. With that the existing tooling would just create a single massive css file.

Concatenating the css after the fact is complicated, mostly because of source-map support. There are ways to make it work, but it pushes the LOE over my "couple hours" threshold. I've tried to do this twice now.

@jbudz
Copy link
Member

jbudz commented Aug 13, 2019

Merging with #36186

@jbudz jbudz closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

4 participants