Highlight row in Discover instead of just the value

[alexfrancoeur]

When searching for something in Kibana, it will display the highlighted fields at the top in discover, which is great.
However, once the doc is expanded to show all fields, the fields are sorted alphabetically (which is great too). However, it is now every hard to find the field that is highlighted, as the yellow does not really stick out too much, especially when the value that matched was not long.
Imagine searching for 443 in Kibana and the dest.port field matches. That field is now one of 50 fields in the document and very hard to see.

One way to resolve this issue would be to highlight the full row of that document, in addition to the text, in a different color, so it's easier to tell which fields matched.

[elasticmachine]

Pinging @elastic/kibana-design

[elasticmachine]

Pinging @elastic/kibana-app

[sainthkh]

@kertal Can I pick this up?

[timroes]

@sainthkh Thanks a lot for being eager to jump on this one. Since we're currently redesigning Discover completely and moving it over to React in which case it will get a completely new Table component, I think it doesn't make that much sense picking this up at the moment, since we'd anyway replace the table component in the next upcoming versions and maybe would even need to change the behavior of this slightly.

[sainthkh]

@timeroes

1.
Thanks for your kind comment. Actually, I've read the related code and thought some codes are a bit hacky. (I'm not blaming. I know it's currently the best solution.) And thought I might need to stop, wait and see.

2.
But a note here. Currently, there's a bug in this highlight feature:

When you search number type fields, it doesn't highlight at all. For example, if you set Kibana with sample flight data and search dayOfWeek: 2, 2 isn't highlighted.

As it's related with angular field formatter, maybe it should be fixed first. If that thing is done, it might not be a problem.

3.
I have a question. Currently, Eui Datagrid is in spec stage. As the spec is really big, I guess it'll take at least 1-2 months to get the beta version of the UI.

Then, Discover new design starts with current EUI table and migrates one more time to Datagrid or just waits until Datagrid is done?

[kertal]

thx a lot for your feedback @sainthkh

1. Yes, e.g. the formatter produces angular-flavored markup, the react component does some cleanup, will be improved when all is react 🎉

2. In Kibana we're using the content of the highlight field returned by Elasticsearch. When I filter for dayOfWeek, this field is not part of highlight, think it's because it's a integer field.

3. Currently discover is mainly deangularized. Where it makes sense, we switch to use EUI components. We won't use EUI table, will use Datagrid once it's ready for discover

[kertal]

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.