Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Delete selected" from dashboard-only users #35766

Closed
xeraa opened this issue Apr 29, 2019 · 5 comments
Closed

Remove the "Delete selected" from dashboard-only users #35766

xeraa opened this issue Apr 29, 2019 · 5 comments
Assignees
Labels
Feature:Dashboard Dashboard related features good first issue low hanging fruit still valid? Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed

Comments

@xeraa
Copy link

xeraa commented Apr 29, 2019

Describe the feature:

If you are logged in as a dashboard-only user and you select one or more dashboards in the overview, then the button "Delete selected" appears. It will fail when being clicked (I assume because of the lack of write permissions to the .kibana index). But a user was very concerned about it today and thought he had found a major bug. I agree that it is a bit confusing and we should be hiding the button if the user lacks the permissions.

Kibana 2019-04-30 01-36-54

Describe a specific use case for the feature:

Less confusion of users.

@xeraa xeraa added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@kobelb
Copy link
Contributor

kobelb commented Apr 30, 2019

I agree that we should be hiding the delete button when the user isn't able to delete the dashboard. When we added Feature Controls we hooked into the existing "hideWriteControls" built into Dashboards, which will need to be revised to also hide the delete button.

@kobelb kobelb removed the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Jun 19, 2019
@timroes timroes added the good first issue low hanging fruit label Oct 29, 2019
@jondlm
Copy link

jondlm commented Jan 25, 2020

Hi. I'm a new contributor that was attracted by the "good first issue" label. Anyway, I looked into this issue and found that the dashboard-only mode was removed in 7.4 (ref #50441) in favor or the RBAC approach (AFAICT). I also found that the issue doesn't seem to manifest anymore with read only role permissions. When a user only has read permissions for dashboards they don't have the ability to select items and delete them. I did my testing on the latest on master (88ba41f).

Seems to me this issue should either be closed or a fix should be back ported into a previous version. I'll leave that up to you folks to decide.

image

@sulemanof
Copy link
Contributor

Kibana user, which was granted access to Dashboard with read only privilege, isn't allowed to select or delete any item from the list of saved dahboards:

image

Tested on master / 7.8 release branch, works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features good first issue low hanging fruit still valid? Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed
Projects
None yet
Development

No branches or pull requests

7 participants