Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Profiler close button not visible when expanding View Details on a section #35639

Closed
geekpete opened this issue Apr 26, 2019 · 5 comments · Fixed by #35990
Closed

Search Profiler close button not visible when expanding View Details on a section #35639

geekpete opened this issue Apr 26, 2019 · 5 comments · Fixed by #35990
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@geekpete
Copy link
Member

Kibana version: 7.0.0

Elasticsearch version: 7.0.0

Server OS version:

Also tested on an Elastic Cloud cluster with the same reproducibility.

Locallty tested on:

> cat /etc/lsb-release
DISTRIB_ID=elementary
DISTRIB_RELEASE=5.0
DISTRIB_CODENAME=juno
DISTRIB_DESCRIPTION="elementary OS 5.0 Juno"
peter@obsidian /home/peter

> cat /etc/upstream-release/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.2 LTS"

Browser version:

Reproducible on:

  • Firefox 66.0.3
  • Chrome 74.0.3729.108 (Official Build) (64-bit) (vanilla install)

Not reproducible (eg, works as it should) on:

  • Chromium 73.0.3683.103 (Official Build) snap (64-bit) (vanilla install)

Browser OS version:

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.10
DISTRIB_CODENAME=cosmic
DISTRIB_DESCRIPTION="Ubuntu 18.10"

Original install method (e.g. download page, yum, from source, etc.):

On the local environment, installed via official OS packages from official repo.

Describe the bug:

Depending on browser, when clicking on View Details for a component fo the profile analysis, if the resulting text for the detail is long enough to go off the visible screen area then you cannot see the Close button for that panel and also cannot scroll or even "select drag scroll" to get down to the Close button to be able to close that detail panel.

Steps to reproduce:

  1. Profile a query that's complex enough to produce enough text that will go outside the visible screen area when clicking More Detail on a component (like a large bool query).
  2. Click View Details using one of the affected browser versions.
  3. Try to find the Closebutton if the text flows off the visible screen area.

Expected behavior:

The close button should always be visible to close the Detail panel and perhaps a scroll mechanism should be provided to view long detail text.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@geekpete geekpete added Feature:Console Dev Tools Console Feature :profiler labels Apr 26, 2019
@geekpete
Copy link
Member Author

geekpete commented May 1, 2019

After a recent Chromium update to Version 74.0.3729.108 (Official Build) snap (64-bit), Chromium is now also showing the errant behaviour of not showing the Close button when drilling into View Details

profiler-no-close-button-1

rather than show the close button:

close-button

@geekpete
Copy link
Member Author

geekpete commented May 1, 2019

Doesn't seem to affect Opera (on Linux):

Opera Version: Your version is 60.0.3255.70

@rayafratkina rayafratkina added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label May 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@cjcenizal cjcenizal added the bug Fixes for quality problems that affect the customer experience label May 2, 2019
@cjcenizal
Copy link
Contributor

@cchaos Could this have been introduced by #33445?

@cchaos
Copy link
Contributor

cchaos commented May 2, 2019

No, I think that is actually part of the Chrome bug introduced in v.74. It's been fixed in EUI via elastic/eui#1902 which just made it into master a little bit ago via #35970. Looks like this one has one extra step since it's got an extra angular component in there. I put up a PR (#35990), mind reviewing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants