Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new platform] Explicitly define service setup types #34416

Closed
5 of 8 tasks
rudolf opened this issue Apr 3, 2019 · 2 comments
Closed
5 of 8 tasks

[new platform] Explicitly define service setup types #34416

rudolf opened this issue Apr 3, 2019 · 2 comments
Assignees
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@rudolf
Copy link
Contributor

rudolf commented Apr 3, 2019

Explicitly define service setup types instead of using the pattern type ReturnType<MyService['setup']>;

src/core/public:

src/core/server:

  • [ ]
@nreese nreese added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Apr 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@pgayvallet
Copy link
Contributor

Closing, as we are no longer using the ReturnType syntax in any of the listed services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

5 participants