Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Update asset manager background image for dark mode #33604

Closed
ryankeairns opened this issue Mar 20, 2019 · 4 comments
Closed

[Canvas] Update asset manager background image for dark mode #33604

ryankeairns opened this issue Mar 20, 2019 · 4 comments
Assignees
Labels
Feature:Canvas loe:small Small Level of Effort Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Mar 20, 2019

The Canvas "transparent" background pattern used in the assets manager doesn't work so well in dark mode:

Dark mode (too much contrast with foreground image)

screen shot 2019-03-07 at 22 05 54 pm

Light mode (lighter color; better for contrast with foreground image)

Screenshot 2019-03-20 14 24 03

Originally posted by @cchaos in #32728 (comment)

@ryankeairns ryankeairns added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1 cqliu1 added loe:medium Medium Level of Effort loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Mar 21, 2019
@crob611 crob611 self-assigned this Mar 25, 2019
@crob611
Copy link
Contributor

crob611 commented Mar 25, 2019

@ryankeairns The background grid pattern is using #DDD and whatever background color it is over to form the grid, so in dark mode it is #1D1E24.

Here is forcing the grid to stay #FFF/#DDD in dark mode. Does this seem reasonable for every theme, or do you think there is some theme color combination we could use to keep it inline with the theme? It seems like we'd always end up with something darker than we would like if we were using some theme combination.

image

@ryankeairns
Copy link
Contributor Author

@crob611 Thanks for looking into this. I think this is a special case where that background color should stay the same regardless of theme, as you noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas loe:small Small Level of Effort Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants