Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Jest Integration Tests.src/cli/serve/integration_tests - cli invalid config support exits with statusCode 64 and logs a single line when config is invalid #32240

Closed
kibanamachine opened this issue Feb 28, 2019 · 23 comments · Fixed by #98699
Assignees
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 28, 2019

A test failed on a tracked branch


        Error: expect(received).toBe(expected) // Object.is equality

Expected: 64
Received: 1
    at Object.toBe (/var/lib/jenkins/workspace/elastic+kibana+6.7/JOB/kibana-intake/node/immutable/kibana/src/cli/serve/integration_tests/invalid_config.test.js:48:20)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+6.7/JOB/kibana-intake/node/immutable/kibana/node_modules/jest-jasmine2/build/jasmine_async.js:108:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+6.7/JOB/kibana-intake/node/immutable/kibana/node_modules/jest-jasmine2/build/queue_runner.js:56:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+6.7/JOB/kibana-intake/node/immutable/kibana/node_modules/jest-jasmine2/build/queue_runner.js:43:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+6.7/JOB/kibana-intake/node/immutable/kibana/node_modules/jest-jasmine2/build/queue_runner.js:87:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)
      

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@spalger
Copy link
Contributor

spalger commented Feb 28, 2019

Fixed by #32242

@spalger spalger closed this as completed Feb 28, 2019
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 29, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

spalger added a commit that referenced this issue Apr 29, 2021
spalger added a commit to spalger/kibana that referenced this issue Apr 29, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

spalger added a commit that referenced this issue Apr 29, 2021
(cherry picked from commit 71145a6)
@spalger spalger added blocker skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 labels Apr 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 29, 2021
@spalger
Copy link
Contributor

spalger commented Apr 29, 2021

Skipped

master/8.0: 71145a6
7.x/7.14: 4e3a93f
7.13: 9873d4c

@spalger
Copy link
Contributor

spalger commented Apr 29, 2021

Looks like APM is complaining about metadata requests did not finish, possible deadlock in flaky test run done in

pr: #98699
flaky test failure: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1522/testReport/junit/Jest%20Integration%20Tests/src_cli_serve_integration_tests/Kibana_Pipeline___agent_1___cli_invalid_config_support_exits_with_statusCode_64_and_logs_a_single_line_when_config_is_invalid_2/

Fix for the test should be easy enough but that log message is unexpected and probably worth looking into

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@afharo
Copy link
Member

afharo commented Apr 29, 2021

The error is caused by the module elastic-apm-node. It logs the entry

{"log.level":"error","@timestamp":"2021-04-29T04:56:27.104Z","log":{"logger":"elastic-apm-node"},"ecs":{"version":"1.6.0"},"message":"metadata requests did not finish, possible deadlock"}

So the test fails when trying to apply the filter line.tags.includes('fatal'):
https://github.com/elastic/kibana/blob/master/src/cli/serve/integration_tests/invalid_config.test.ts#L41

I'll fix the test so it doesn't assume tags always exist. I will submit a PR asap :) Oh! I see @spalger was quicker in the fix! Thank you!

@afharo afharo self-assigned this Apr 29, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

jbudz pushed a commit that referenced this issue Apr 29, 2021
@jbudz
Copy link
Member

jbudz commented Apr 29, 2021

Added a skip to 7.13: 9873d4c

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants