Vega 5 support

[flash1293]

Vega 5 will be released soon and should be supported by Kibana.

Starting with Vega 4.4, IE 11 isn't supported anymore, which causes Kibana to throw an error on loading. This means the build process has to be configured to correctly compile down the language features used in the code of the vega dependency (and maybe add necessary polyfills for APIs unsupported in IE).

• Wait for vega 5 to be releases
• Update vega (switch from vega-lib) and vega-lite
• Investigate IE 11 errors
• Extend webpack build config (packages/kbn-babel-preset) to correctly compile everything down

Related Links:

• Supporting Internet Explorer Vega doc

[elasticmachine]

Pinging @elastic/kibana-app

[lizozom]

This tooltip issue will be resolved when this happens.
I will need to clean up the code once it does.

[wylieconlon]

I think this checklist is no longer accurate because vega now builds to ES5 (vega/vega#2179) thanks to @nyurik. The Vega docs page about supporting IE11 seems to be out of date as a result. We need to test the ES5 build to see if will work for us, which is a simpler task than changing our webpack settings.

[flash1293]

Wow, that's great! Thank you so much @nyurik . @wylieconlon I'll look into this if you haven't started already.

[nyurik]

Note that Vega-Lite is still in the process of upgrading -- keep an eye on vega/vega-lite#5920 . I think it is OK for the Vega-Lite to be kept back for a bit until its ES5 situation clears up.

[wylieconlon]

Did some initial work on this. The upgrade seems okay in Chrome, but I can't get it to load in browserstack IE11. If one of you wants to investigate, that would be very helpful: #58545

[wylieconlon]

Progress on vega-lite with ES5 builds, this is now the PR to follow: vega/vega-lite#6280

The remaining steps as I see them:

1. Wait for vega-lite to release a version with ES5 build
2. Upgrade to vega 5 and vega-lite 4 together with this PR Vega 5 upgrade #58545
3. Test in IE11

One thing that wasn't clear to me from the original report was what errors we were commonly seeing in IE11- does anyone have a list?

[wylieconlon]

Okay, so in the last couple hours a new release of vega-lite went out. We are now unblocked from further work.

[wylieconlon]

One of the issues I found with upgrading to Vega 5 is that there are some failures in the Kibana sample Vega visualizations:

Infinite extent for field "y1": [Infinity, -Infinity]

Infinite extent for field "_source.bytes": [Infinity, -Infinity]

Cannot read property 'expressionFunction' of undefined

These failures indicate a bigger issue, and we potentially need to do more work on migrating from old Vega to new Vega.