Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Enhance status code presentation in the Transaction sample header #29928

Closed
9 tasks
formgeist opened this issue Feb 4, 2019 · 11 comments
Closed
9 tasks
Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Feb 4, 2019

Summary

Enhancing the visual presentation of the HTTP status code in the Transaction header.

Screenshot 2019-02-04 at 09.57.41.png

Solution

Highlight especially 4xx and 5xx status codes, because assumptions are that users are most interested in these being highlighted in the Transaction header, Timeline visualization and Transaction detail flyouts.

  • Convert 4xx and 5xx status code labels to EuiBadge with their respective visualization colours from the TPM graph.
    • 4xx: euiColorVis7
    • 5xx: euiColorVis2
  • Show badges replacing labels in;
    • Transaction header
    • Span row design
    • Transaction detail flyout
  • Strip out 2xx and 3xx from the span row design in Timeline
  • Remove euiColorVis7 and euiColorVis2 from our common service visualization palette used in Timeline assigned to services rendered. This is avoid confusing colour combinations, when we want to highlight.

Example of 4xx result transaction
02 transaction result - 4xx

Example of 5xx result transaction
01 transaction result - 5xx

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist formgeist self-assigned this Feb 4, 2019
@formgeist formgeist added Team:APM All issues that need APM UI Team support [zube]: Inbox design and removed [zube]: Inbox design labels Feb 4, 2019
@formgeist formgeist removed their assignment Feb 4, 2019
@formgeist
Copy link
Contributor Author

Moved to implementation

@formgeist
Copy link
Contributor Author

Idea: To avoid clashing with the applied colour palette for services (which is just the default visualization palette), we could exempt the 4 colours we use for the Transaction result. That way they'll never mix.

@sorenlouv
Copy link
Member

we could exempt the 4 colours we use for the Transaction result

I'm good with that. How many colors will that leave us with for services?

@formgeist
Copy link
Contributor Author

@sqren Like 5 🙈But we have to find a more scaleable solution to this issue in any case, if that's a bigger range of colours in our services palette.

@sorenlouv
Copy link
Member

Oh, not a lot. But yeah, we need a more scalable solution regardless...

@makwarth
Copy link

We could just highlight 4xx (one shade of red) and 5xx (another shade of red), meaning good responses are just displayed as today (plain text). That's "just" 2 colors.

@formgeist
Copy link
Contributor Author

Sounds like a good plan to me. So only using EuiBadge for 4xx and 5xx status codes in the view will look something like this;

02 transaction result - 4xx
01 transaction result - 5xx

Would like to get a PR up next week, where we can try this out and see how it feels. I also like the fact that we'd only take out 2 colours from our services colour palette, and ones that anyways immediately would catch the attention of users because they're "warning orange" and "screaming red".

@makwarth
Copy link

LGTM 👍

@formgeist
Copy link
Contributor Author

Updated description with the decided changes

@sorenlouv
Copy link
Member

Fixed in #44842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

4 participants