-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Enhance status code presentation in the Transaction sample header #29928
Comments
Pinging @elastic/apm-ui |
Moved to implementation |
Idea: To avoid clashing with the applied colour palette for services (which is just the default visualization palette), we could exempt the 4 colours we use for the Transaction result. That way they'll never mix. |
I'm good with that. How many colors will that leave us with for services? |
@sqren Like 5 🙈But we have to find a more scaleable solution to this issue in any case, if that's a bigger range of colours in our services palette. |
Oh, not a lot. But yeah, we need a more scalable solution regardless... |
We could just highlight 4xx (one shade of red) and 5xx (another shade of red), meaning good responses are just displayed as today (plain text). That's "just" 2 colors. |
Sounds like a good plan to me. So only using Would like to get a PR up next week, where we can try this out and see how it feels. I also like the fact that we'd only take out 2 colours from our services colour palette, and ones that anyways immediately would catch the attention of users because they're "warning orange" and "screaming red". |
LGTM 👍 |
Updated description with the decided changes |
Fixed in #44842 |
Summary
Enhancing the visual presentation of the HTTP status code in the Transaction header.
Solution
Highlight especially 4xx and 5xx status codes, because assumptions are that users are most interested in these being highlighted in the Transaction header, Timeline visualization and Transaction detail flyouts.
EuiBadge
with their respective visualization colours from the TPM graph.euiColorVis7
euiColorVis2
euiColorVis7
andeuiColorVis2
from our common service visualization palette used in Timeline assigned to services rendered. This is avoid confusing colour combinations, when we want to highlight.Example of 4xx result transaction
Example of 5xx result transaction
The text was updated successfully, but these errors were encountered: