Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization query errors hidden #29900

Closed
spalger opened this issue Feb 2, 2019 · 4 comments · Fixed by #30594
Closed

Visualization query errors hidden #29900

spalger opened this issue Feb 2, 2019 · 4 comments · Fixed by #30594
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0

Comments

@spalger
Copy link
Contributor

spalger commented Feb 2, 2019

Kibana version: master
Elasticsearch version: master
Original install method (e.g. download page, yum, from source, etc.): source

Describe the bug:

When an invalid query is typed into the filter bar, or a filter aggregation, and sent to Elasticsearch. The error that comes back from elasticsearch is not shown to the user and the app just looks unresponsive.

Steps to reproduce:

  1. Create a new visualization
  2. In a filter aggregation use the filter :"FOO"
  3. Update the visualization

Expected behavior:

The error should be shown to the user so they can fix their query

Errors in browser console (if relevant):
image

@spalger spalger added blocker Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes
Copy link
Contributor

timroes commented Feb 4, 2019

cc @lukeelmers @ppisljar could you check if that's gone once the infrastructure is reverted

@ppisljar
Copy link
Member

ppisljar commented Feb 5, 2019

not happening after revert

@ppisljar
Copy link
Member

ppisljar commented Feb 5, 2019

pipeline_data_loader catches the errors, but doesn't show the toast (the way visualize_data_loader does).
code for error handling should be extracted and used in both.

@stacey-gammon stacey-gammon added bug Fixes for quality problems that affect the customer experience Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) and removed :pipeline-bugs labels Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants