Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Refactor filters to use less open API #29745

Closed
andrewvc opened this issue Jan 31, 2019 · 2 comments
Closed

[Uptime] Refactor filters to use less open API #29745

andrewvc opened this issue Jan 31, 2019 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@andrewvc
Copy link
Contributor

The current GQL API for filters involves passing in whole ES filter blocks in JSON. This is not very clean and is problematic for a number of reasons.

We should replace these with more specific APIs that don't take filter syntax, but rather just the minimum number of parameters to accomplish the work.

This came up in a few places notably #29557 (comment)
@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

This was referenced Jan 31, 2019
Closed
Merged
@andrewvc andrewvc closed this as completed Feb 7, 2019
@andrewvc
Copy link
Contributor Author

andrewvc commented Feb 7, 2019

This is actually not a problem at all due to Kibana's security model, where it basically acts as a proxy with the user's creds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewvc @elasticmachine