Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean scripted fields aren't handled correctly in the filter bar #28378

Closed
Tracked by #166068
Bargs opened this issue Jan 9, 2019 · 5 comments
Closed
Tracked by #166068

Boolean scripted fields aren't handled correctly in the filter bar #28378

Bargs opened this issue Jan 9, 2019 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters Feature:Search Querying infrastructure in Kibana Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@Bargs
Copy link
Contributor

Bargs commented Jan 9, 2019

Kibana version: master
Elasticsearch version: master

Describe the bug:

When creating a filter on a boolean scripted field matching the value false the filter pill displays the full script instead of a human readable display name.

The problem is that we're returning params.value here which incorrectly tells the phrase mapper that this is not a scripted field. At the moment I'm not sure why we're returning params.value so we need to look into that a bit before we'll know what the appropriate fix is.

Steps to reproduce:

  1. Create a boolean scripted field
  2. Create a filter on it for the value false using the Add Filter UI
  3. Notice the text in the filter pill that gets created

Screenshots (if relevant):

screen shot 2019-01-09 at 11 53 54 am

@Bargs Bargs added Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@lukasolson lukasolson added the bug Fixes for quality problems that affect the customer experience label Apr 20, 2022
@lukasolson
Copy link
Member

Still an issue, though the behavior now doesn't show the whole scripted field, it shows basically nothing:

image

@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Apr 20, 2022
@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Sep 27, 2024

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters Feature:Search Querying infrastructure in Kibana Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

6 participants