Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more aggressive URL encoding #2815

Closed
peterskim12 opened this issue Jan 30, 2015 · 7 comments
Closed

Use more aggressive URL encoding #2815

peterskim12 opened this issue Jan 30, 2015 · 7 comments
Labels
bug Fixes for quality problems that affect the customer experience discuss

Comments

@peterskim12
Copy link

I attempted to enter a link into a Confluence wiki page as follows:

http://localhost:5601/#/dashboard/USFEC:-Overview?_g=(time:(from:'2012-11-01T16:33:29.911Z',mode:absolute,to:'2015-01-29T17:48:29.911Z'))

Apparently Confluence didn't like the link and believed it to be a bad URL. After I ran the _g param value through a URL encoder:

http://localhost:5601/#/dashboard/USFEC:-Overview?_g=(time%3A(from%3A%272012-11-01T16%3A33%3A29.911Z%27%2Cmode%3Aabsolute%2Cto%3A%272015-01-29T17%3A48%3A29.911Z%27))

and inserted that link into Confluence, it was much happier and the link rendered properly.

The Rison doc page suggests that some applications can be very conservative about what it considers a valid URL and the default URLs params generated by Rison could be considered invalid by some applications.

I think a lot of people will be copying/pasting Kibana links from their browser to email or other applications that may not believe the URL is valid. It's worth considering using a more aggressive URL encoder as Rison suggests.

https://github.com/Nanonid/rison

@rashidkpc
Copy link
Contributor

I'm not a fan of the more aggressive URL encoding, it is hard to read and causes the size of the already lengthy URL to expand by 20%+. I'd like to see this implemented as a URL shortener supplied perhaps via a globally's available "share" button.

@ohTHATaaronbrown
Copy link

+1 for url-shortening via share button.

@teknogeek0
Copy link

+1 on url-shortening via any sort of method

@rcrezende
Copy link

+1

@ppf2 ppf2 added the bug Fixes for quality problems that affect the customer experience label May 10, 2016
@ppf2
Copy link
Member

ppf2 commented May 10, 2016

+1 Clarifying the request here per conversation with @epixa . Basically, regardless of whether you use the url shortener or not, any link we generate in Kibana should url encode all the data to support integration with other systems.

@pjangam
Copy link

pjangam commented Jun 3, 2017

+1

@rashidkpc
Copy link
Contributor

We implemented a URL shortener. This one is dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience discuss
Projects
None yet
Development

No branches or pull requests

8 participants