Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grouping] Remove setTimeout when duplicating elements #27456

Closed
w33ble opened this issue Dec 18, 2018 · 1 comment · Fixed by #27581
Closed

[Grouping] Remove setTimeout when duplicating elements #27456

w33ble opened this issue Dec 18, 2018 · 1 comment · Fixed by #27581
Assignees
Labels
chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@w33ble
Copy link
Contributor

w33ble commented Dec 18, 2018

Kibana version: 6.6+

Describe the bug:

Pulled from this comment on #25854.

When the rawDuplicateElement action is used, there's an element selection that happens in a setTimeout at the end. It's mostly a hacky workaround to wait for aeroelastic to update, and seems really prone to race conditions.

From @monfera:

I want to circle back to this one, the element in aeroelastic is not present yet if done synchronously, so it can't select (pasting will create a new group, naturally with a new id). So the purpose is to switch selection to the newly pasted thing, even if it's a group. I think it's due to the fact that cloning is done outside aero but selection is in good part, inside (eg. to activate the resize frame). I'm sometimes thinking about a different synchronization between aero and the Redux actions / thunks, it got fairly convoluted. Something I'm planning to touch on on our Jan 10 discussion on the layout engine.

@w33ble w33ble added chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Dec 18, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants