Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize runs twice when starting from a clean repo #27274

Closed
spalger opened this issue Dec 15, 2018 · 3 comments · Fixed by #73154
Closed

Optimize runs twice when starting from a clean repo #27274

spalger opened this issue Dec 15, 2018 · 3 comments · Fixed by #73154
Labels
Feature:Build Tooling Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Dec 15, 2018

Kibana version: master

Describe the bug: When the optimizer is run on a previously cleaned repo it runs twice for some reason

Steps to reproduce:

  1. yarn kbn clean
  2. node scripts/kibana --dev

Expected behavior: optimize should only run once initially

Screenshots (if relevant):

image

@spalger spalger added bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team labels Dec 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@mistic
Copy link
Member

mistic commented Dec 15, 2018

@spalger I think this is not a bug but is an expected result from what is happening. We are in watch mode and as we are compiling the DLL in the first run (and creating/changing files like the entry file and the manifest) a new watch compilation is triggered. Maybe we need to do one more cache purge into the entry file here https://github.com/elastic/kibana/blob/master/src/optimize/dynamic_dll_plugin/dynamic_dll_plugin.js#L465 in order to avoid the second compilation

@spalger spalger removed the bug Fixes for quality problems that affect the customer experience label Dec 15, 2018
@spalger
Copy link
Contributor Author

spalger commented Dec 15, 2018

Yeah, it's probably fine to not consider this a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Build Tooling Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants