Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Layout Engine] Suggestion: Layer Selector #25505

Closed
aphelionz opened this issue Nov 10, 2018 · 4 comments
Closed

[Accessibility][Layout Engine] Suggestion: Layer Selector #25505

aphelionz opened this issue Nov 10, 2018 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A

Comments

@aphelionz
Copy link
Contributor

aphelionz commented Nov 10, 2018

Fast follow-on to #25503 - if there is a keyboard accessible way to move the Selected layer then there should also be a keyboard-accessible way to select a layer, perhaps something like the Layers panel in Photoshop.

#24159 Kibana 6.5 Meta Issues
#23534 Canvas Accessibility

Relevant WCAG Criteria: 2.1.1 Keyboard

@aphelionz aphelionz added Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 11, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@aphelionz aphelionz changed the title Layer Selector needed [Accessibility] Suggestion Layer Selector Nov 11, 2018
@aphelionz aphelionz changed the title [Accessibility] Suggestion Layer Selector [Accessibility] Suggestion: Layer Selector Nov 11, 2018
@monfera monfera changed the title [Accessibility] Suggestion: Layer Selector [Accessibility][Layout Engine] Suggestion: Layer Selector Dec 13, 2018
@rayafratkina
Copy link
Contributor

Not sure how feasible this is short-term?

@monfera
Copy link
Contributor

monfera commented Feb 25, 2019

Our terminology on layers and layering hasn't been consistent so I'll try to clarify this first:

  1. Layers: things like layers, selected layer, layers panel, disable editing of a layer etc should refer to discrete layers similar to those in vector editing software, as you refer to, a functionality that doesn't exist yet in Canvas, but it should and part of this issue refers to it
  2. Vertical positioning of elements or groups, a functionality that exists now, and which now has keyboard controls in addition to the sidebar buttons (we confusingly call it layering here and there)

It's a fair point that for accessibility, it's not enough that vertical positioning is enabled via keyboard action - indeed, selection should be possible too.

So let's understand this issue to

  • A. primarily require that elements and groups be selectable via keyboard shortcuts,
  • B. secondarily, suggest (support) that we should eventually add layers support (as in item 1) and shortcuts for that

The question regarding item A is, I think it'd be a relatively uncomplicated development to add once I'm done with the layout engine middleware refactoring, or even parallel with it if there's availability, @cqliu1 @ryankeairns please add your thoughts, eg. keys to cycle through elements / groups

@cqliu1 cqliu1 added the loe:large Large Level of Effort label Mar 19, 2019
@clintandrewhall clintandrewhall added the bug Fixes for quality problems that affect the customer experience label Jun 10, 2019
@timductive timductive mentioned this issue Oct 23, 2019
14 tasks
@clintandrewhall clintandrewhall added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 1, 2021
@nickpeihl nickpeihl added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 26, 2023
@nreese
Copy link
Contributor

nreese commented Apr 6, 2023

Closing as not planned

@nreese nreese closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A
Projects
None yet
Development

No branches or pull requests

9 participants