Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inspector/DataViewComponent] does not work with React 16.4+ #25088

Closed
spalger opened this issue Nov 2, 2018 · 1 comment
Closed

[Inspector/DataViewComponent] does not work with React 16.4+ #25088

spalger opened this issue Nov 2, 2018 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@spalger
Copy link
Contributor

spalger commented Nov 2, 2018 •
edited
Loading

When upgrading to the latest version of React the inspector's DataViewComponent breaks because the getDerivedStateFromProps() method overrides state.tabularPromise each time it is updated in finishLoadingData().

kibana/src/core_plugins/inspector_views/public/data/data_view.js

Line 51 in 4fe2f1d

tabularPromise: nextProps.adapters.data.getTabular(),

@spalger spalger added bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 2, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@spalger spalger mentioned this issue Nov 3, 2018
Merged
1 task
@spalger spalger mentioned this issue Nov 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spalger @elasticmachine