Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Change "response time" label to "duration" for all transaction types for all agents #24722

Closed
6 tasks
formgeist opened this issue Oct 29, 2018 · 5 comments
Closed
6 tasks
Assignees
Labels
Team:APM All issues that need APM UI Team support v6.6.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Oct 29, 2018

Summary

We want to simplify the UI by changing the "response time" label (which actually only made sense for the transaction type "request") to "duration" for all transaction types for all agents. This means there's no differentiation to keep track of from different transaction types.

Tasks

  • Transactions overview page
    • Response time chart: Response times -> Transactions duration
    • Transactions list: Avg. resp. time -> Avg. duration
  • Transaction detail page
    • Same change as above to the charts
    • Response time distribution histogram: Response time distribution -> Transactions duration distribution

Examples

Transactions list

screencapture-localhost-5601-tdw-app-apm-2018-10-29-13_42_23.png

Transaction detail page

screencapture-localhost-5601-tdw-app-apm-2018-10-29-13_43_18 (1).png

@formgeist formgeist added Team:APM All issues that need APM UI Team support [zube]: Inbox labels Oct 29, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@jasonrhodes
Copy link
Member

Would it be ok to just change it to "duration" across the board (and not check for "if request, keep as resp time")? Would be nice to reduce the complexity there and "duration" is always true, not sure it's necessary to treat one type special with wording?

@formgeist
Copy link
Contributor Author

I believe we're going back and forth on whether to support more language-specific terminology in the UI. In my opinion, we're delivering a curated UI for the languages, and that means supporting the terminology that best fits the standards of that language. That wasn't so much a comment to choosing duration over response time for requests, which I think we could agree on, but especially the RUM agent has very specific transaction types that demands another terminology, so if we start in one place, we may already have to have a system in place to handle different units or terms for transactions for the different languages. Would like to know what @roncohen or @makwarth thinks about unification > customization when we're thinking about the user experience.

@makwarth
Copy link

makwarth commented Oct 31, 2018

I'm leaning towards "duration" for all languages. As long as the transaction type is clear (which I think it is atm), it will be quite clear what "duration" refers to. E.g. for RUM, you're on the "Page load times" tab and the chart title is "duration".

@formgeist
Copy link
Contributor Author

@makwarth Ok, that sounds good. I'll update the description and title of this issue, so it's clear what needs to happen.

@formgeist formgeist changed the title [APM] Change "Response time" label for everything but transaction type "Request" [APM] Change "response time" label to "duration" for all transaction types for all agents Nov 7, 2018
@ogupte ogupte self-assigned this Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v6.6.0
Projects
None yet
Development

No branches or pull requests

6 participants