Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Condensed Element Selector #23324

Closed
alexfrancoeur opened this issue Sep 19, 2018 · 2 comments
Closed

[Canvas] Condensed Element Selector #23324

alexfrancoeur opened this issue Sep 19, 2018 · 2 comments
Assignees
@ryankeairns
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@alexfrancoeur
Copy link

alexfrancoeur commented Sep 19, 2018 •
edited
Loading

image

From #23176 (comment)

It's not a result of the changes in this PR. EUI applies a max-width of 768px to all modals which was added in a recent update. We can override the style if we want the modal to be wider in a separate PR.

The max width from EUI makes for an interesting modal experience. Can we adjust?

@cqliu1 @rashidkpc @ryankeairns
@alexfrancoeur alexfrancoeur added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 19, 2018
@alexfrancoeur alexfrancoeur mentioned this issue Sep 19, 2018
Merged
@ryankeairns
Copy link
Contributor

@alexfrancoeur I adjusted the modal widths here #23250 to the original max widths we were using prior to this EUI update. Have a look and perhaps we can close this issue.

@ryankeairns ryankeairns self-assigned this Sep 19, 2018
@ryankeairns
Copy link
Contributor

Closing this one as there was a PR merged just prior to this that addressed the width of the modal. I suspect you may not have been all up to date with master.

Related, there is an issue to address the thumbnail/preview images that will also tidy up the contents of this modal --> #23510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryankeairns ryankeairns

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryankeairns @marius-dr @alexfrancoeur