Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Research and spec undo/redo performance #23041

Closed
kibanamachine opened this issue Sep 14, 2017 · 2 comments
Closed

[Canvas] Research and spec undo/redo performance #23041

kibanamachine opened this issue Sep 14, 2017 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance spec A project we are committed to working on that needs a spec. Promote to a `meta` when done Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kibanamachine
Copy link
Contributor

Original comment by @w33ble:

We shouldn't need to flush resolved args when the history is restored, we should be able to trash elements that went away, or trigger an update only on the ones being added.

This change would speed up undo/redo significantly, but is likely to be pretty involved since you need to make sure transient state stays in sync with persisted state as the history changes it.
@kibanamachine
Copy link
Contributor Author

Original comment by @rashidkpc:

This needs someone to fill in a proposed path for a POC. Eg, "We should maintain 'undo' actions for any action" or something like that. There's probably several paths we could take. Someone spec a POC, and size a POC ticket.

@kibanamachine kibanamachine added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort spec A project we are committed to working on that needs a spec. Promote to a `meta` when done labels Sep 14, 2018
@timductive timductive added enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 10, 2019
@timductive timductive mentioned this issue Oct 23, 2019
Closed
14 tasks
@spalger spalger changed the title Research and spec undo/redo performance [Canvas] Research and spec undo/redo performance Apr 5, 2021
@lizozom
Copy link
Contributor

lizozom commented Apr 18, 2022

Closing due to inactivity.
Feel free to re-open if needed 🙏🏻

@lizozom lizozom closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance spec A project we are committed to working on that needs a spec. Promote to a `meta` when done Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timroes @timductive @lizozom @liza-mae @kibanamachine