Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spaces] Role page should be global and not Space specific #22603

Closed
AlonaNadler opened this issue Aug 31, 2018 · 6 comments
Closed

[Spaces] Role page should be global and not Space specific #22603

AlonaNadler opened this issue Aug 31, 2018 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@AlonaNadler
Copy link

Currently, when configuring a new role, it only allows setting the index patterns of the space the admin is currently at, that's a problem since if there is a role that needs to have the privilege to index patterns in multiple spaces it's not possible to configure this role.
Example:
There are only 2 spaces:

  • Engineering has index pattern A
  • Product has index pattern B

When I want to configure a role that will have a privilege for both index pattern A and B I can't do it.
Role page shouldn't be space specific it should be global

cc: @elastic/kibana-security

@AlonaNadler AlonaNadler added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Aug 31, 2018
@legrego
Copy link
Member

legrego commented Aug 31, 2018

This raises an interesting challenge if the admin configuring roles does not have access to all Spaces (and therefore, all index patterns).

Technically, a user only needs the Elasticsearch manage_security permission, and read access to at least one space to create roles through the Kibana UI/API.
Given that, I think we'll need to come up with a way to only show index patterns that exist within the Spaces the current user has access to.

I'm going to block this on #21995 since we need secured spaces to exist before we can make progress here.

@kobelb
Copy link
Contributor

kobelb commented Sep 4, 2018

For us to address this cleanly and universally, I think we're going to have to add the ability to search for saved objects across spaces, which isn't something we were planning on having to do with the first phase of Spaces. I'd prefer if we address this deficiency in a later phase to ensure we don't introduce a hacky temporary solution and have the time to fully implement this appropriately.

@kobelb kobelb added the enhancement New value added to drive a business result label Sep 4, 2018
@jimgoodwin
Copy link

I think this is a bit misleading. These roles relate to Elasticsearch Indexes not Kibana Index Pattern Objects. What we should be listing here are all of the Elasticsearch Indexes this administrator can see. I get the motivation to use Index Patterns as a shortcut to help them choose something, but in reality they're just choosing that wildcard pattern, not the object itself. I'd be in favor of (in the future) showing the index patterns that they can see, followed by all matching indexes for what they've typed so far after say two or three letters. This is also in my opinion broken in the existing product, so I don't think it needs to be enhanced/corrected immediately.

@kobelb
Copy link
Contributor

kobelb commented Sep 12, 2018

I think this is a bit misleading. These roles relate to Elasticsearch Indexes not Kibana Index Pattern Objects. What we should be listing here are all of the Elasticsearch Indexes this administrator can see. I get the motivation to use Index Patterns as a shortcut to help them choose something, but in reality they're just choosing that wildcard pattern, not the object itself. I'd be in favor of (in the future) showing the index patterns that they can see, followed by all matching indexes for what they've typed so far after say two or three letters. This is also in my opinion broken in the existing product, so I don't think it needs to be enhanced/corrected immediately.

That's a good point, and I think that listing the index patterns in additional to the actual indices in Elasticsearch would be the ideal user experience.

@legrego legrego added the Feature:Security/Spaces Platform Security - Spaces feature label Oct 1, 2018
@legrego
Copy link
Member

legrego commented Jul 26, 2021

We were previously blocked on our inability to search across spaces (#27003), but this has since been resolved (#67644).

With this out of the way, our next steps would be to collaborate on a design to effectively show index patterns ("data views") alongside indices and data streams in an understandable UX, and then prioritize the work to implement this new design.

@legrego legrego added Feature:Users/Roles/API Keys and removed Feature:Security/Spaces Platform Security - Spaces feature labels Jul 26, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 5, 2021
@legrego legrego removed EnableJiraSync loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 18, 2022
@legrego
Copy link
Member

legrego commented Jan 17, 2023

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@legrego legrego closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

4 participants