Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External tile maps will not load on dashboard if dashboard is set to dark #22495

Closed
arenzana opened this issue Aug 29, 2018 · 3 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Coordinate Map

Comments

@arenzana
Copy link

Kibana version: 6.3.0

**Elasticsearch version: 6.3.0 **

Server OS version: CentOS 7.4

Browser version: Firefox 61

Browser OS version: MacOS 10.14

Original install method (e.g. download page, yum, from source, etc.): RPM download

Describe the bug: If I add an external tile map to a visualization in Kibana, it will load correctly. (ie. http://basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png as WMS server). I can now create a Dashboard and the dark map will display correctly. However, if I set the dashboard:defaultDarkTheme option to true and create a new dashboard (it should be dark), the tile map will not load. Perhaps because Kibana fails to change the color set?

Steps to reproduce:

  1. Set the dashboard:defaultDarkTheme to true.
  2. Create a Visualization that includes a custom WMS server.
  3. Create a dashboard (dark) that includes the previously created visualization.

Expected behavior: I would expect the tile map colors to not be changed but load

**Screenshots (if relevant):
screen shot 2018-08-29 at 10 14 00 am
**

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context: I'm using Dark Mode in Mojave, but I don't think that's relevant, really.

@nreese
Copy link
Contributor

nreese commented Aug 29, 2018

The tiles are getting loaded. If you open your browser's dev tools and look under network requests, you can see that the tiles are loaded.

screen shot 2018-08-29 at 2 32 10 pm

The problem is that in dark-mode, a CSS filter is applied to the tile to invert the colors. This makes your tiles show up as all white.

screen shot 2018-08-29 at 2 53 29 pm

Disabling the CSS rule fixes the issue

screen shot 2018-08-29 at 2 53 41 pm

You could remove this line from the CSS https://github.com/elastic/kibana/blob/6.3/src/core_plugins/tile_map/public/styles/_tilemap.less#L196 under the source directory and then remove the optimize folder. Restart kibana and optimize will be re-generated from the source files.

Or just use a light tile set and let the filter invert their color.

@nreese nreese added Feature:Coordinate Map [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation and removed triage_needed :Sharing labels Aug 29, 2018
@thomasneirynck thomasneirynck added the bug Fixes for quality problems that affect the customer experience label Sep 10, 2018
@thomasneirynck
Copy link
Contributor

related to #18657.

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 11, 2019

This is addressed in 7.2. Dark-themed maps are now a first-level tile-service in EMS and Kibana no longer uses a custom CSS rule to manipulate the colors of the tile images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Coordinate Map
Projects
None yet
Development

No branches or pull requests

4 participants