Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non JSON fields on advanced settings don't have a label. #22294

Closed
bhavyarm opened this issue Aug 23, 2018 · 4 comments
Closed

Non JSON fields on advanced settings don't have a label. #22294

bhavyarm opened this issue Aug 23, 2018 · 4 comments
Assignees
@jen-huang
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG A

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Aug 23, 2018 •
edited
Loading

Kibana version: 6.4.0 BC6

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Elements (axe tells me 25 of them) don't have a label on advanced settings.

https://dequeuniversity.com/rules/axe/3.0/label?application=AxeChrome

screen shot 2018-08-23 at 9 47 46 am
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience :Management Project:Accessibility WCAG A labels Aug 23, 2018
@bhavyarm bhavyarm mentioned this issue Aug 23, 2018
Closed
16 tasks
@bhavyarm bhavyarm changed the title Search on advanced settings does not have a label Form elements on advanced settings are missing labels Aug 28, 2018
@bmcconaghy bmcconaghy mentioned this issue Sep 12, 2018
Merged
@bmcconaghy
Copy link
Contributor

The elements on the page that use ace editor can't really have labels added to them as that lib is an a11y mess: ajaxorg/ace#2164. @bhavyarm would you mind creating two separate issues for JSON fields/non JSON fields? I have a fix for the non JSON ones.

@bhavyarm bhavyarm changed the title Form elements on advanced settings are missing labels Non JSON fields on advanced settings don't have a label. Sep 12, 2018
@bhavyarm
Copy link
Contributor Author

@bmcconaghy here you go: #22973 Thank you!

@bmcconaghy
Copy link
Contributor

awesome sauce, thx @bhavyarm

@bmcconaghy
Copy link
Contributor

Closed by #22969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jen-huang @bmcconaghy @bhavyarm