Page refresh on Dashboard with saved time loses time range

[stacey-gammon]

On master. To repro:

1. Create a dashboard with time range saved.
   

2. Refresh the page.
   See it go to "last 15 minutes"
   

There are quite a few time range dashboard bugs open so it could be related:

• Auto refresh is no longer working #20813
• Reports did not match the dashboard #20764

[stacey-gammon]

As of June 21st, this was working.
As of July 5th, this was not working. I suspect #19852 may be the culprit. Will continue digging.
As of commit dbdbb68 - the PR right after the above, it's broken. Looks more and more likely the above PR is the culprit.

Looks like the time portion of the URL is missing.

[tylersmalley]

Checking in on the status of this since it's a blocker for 6.4

[stacey-gammon]

I have a PR that I think fixes it, but I did not get it over the line when I went out on vacation last week. There are failing tests on it, but that's the norm nowadays so now I need to wade through whether they are legit failures or flaky ones (last week there were some legit ones which I thought I fixed right before I left, now I need to go back to verify as the tests are still failing).

[walterra]

@stacey-gammon I'm afraid the PR #20858 caused a regression in the ML plugin documented here #21326

I was able to pin down the regression to be caused by this change: https://github.com/elastic/kibana/pull/20858/files#diff-82d343a079857a203816647e3c33f54eR73

I'm currently investigating how we can fix it on the ML side without any further changes to kbn_global_timepicker.js.

[stacey-gammon]

Oh no! Was the ML code that was affected introduced within the last month? The code that originally caused the bug was introduced on June 26th. If your code was written after that, maybe it was written with incorrect assumptions? If the code that broke has not been touched in awhile then perhaps I incorrectly changed something from how it worked prior to June 26th.

I'm technically off today, but let me know if I can help when I get back on Monday.