Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Persistent Background Error During Rule Save #200252

Closed
pborgonovi opened this issue Nov 14, 2024 · 4 comments
Closed

[Security Solution] Persistent Background Error During Rule Save #200252

pborgonovi opened this issue Nov 14, 2024 · 4 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed

Comments

@pborgonovi
Copy link
Contributor

Describe the bug:
When attempting to save a detection rule with a query referencing an unidentified index in the Description tab, a validation warning is displayed, providing the options to Confirm or Cancel.

  • If the user clicks Confirm, the rule is saved successfully despite the warning.
  • If the user clicks Cancel, the red error message remains visible in the background.

Kibana/Elasticsearch Stack version:
8.x

Current branch: 8.x  
Latest commit: d0c9a2f1f52 - [8.x] [Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043) (#200227)  
Remote tracking: origin/8.x  
Status relative to remote: up to date (no pending commits)  

Server OS version:

Browser and Browser OS versions:

Elastic Endpoint version:

Original install method (e.g. download page, yum, from source, etc.):

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):

Steps to reproduce:

  1. Open a detection rule with an invalid query in the Description tab (e.g., referencing an unknown index such as [.]).
  2. Modify any part of the rule (e.g., update the schedule in the Schedule tab).
  3. Click Save Changes.
  4. Observe the following:
  • A validation warning appears, stating the query could cause execution issues.
  • Clicking Confirm successfully saves the rule, ignoring the warning.
  • Clicking Cancel does not save the rule, and the red error persists in the background.

Current behavior:

  • The red background error message is incorrectly displayed while the validation warning popup is active.
  • The red error persists even if the user cancels the save operation.

Expected behavior:
The red error message in the background should not appear.

  • Confirm: The rule should save successfully after the popup warning is acknowledged.
  • Cancel: The popup warning should close, and the UI should reset to its original state with no residual errors displayed.

Screenshots (if relevant):

Image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):

@pborgonovi pborgonovi added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team triage_needed labels Nov 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@pborgonovi pborgonovi changed the title [Security Solution] Persistent Background Error After Canceling Validation Warning During Rule Save [Security Solution] Persistent Background Error During Rule Save Nov 14, 2024
@banderror
Copy link
Contributor

@pborgonovi This was a quick-and-dirty implementation and this UI is not finished yet. It should be improved as part of #191832. I'll post a link to this bug there to share your suggestions, but close it to not have duplicated tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed
Projects
None yet
Development

No branches or pull requests

3 participants