Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas number formatting must honor Space locale setting #199126

Closed
dolivanu opened this issue Nov 6, 2024 · 2 comments
Closed

Canvas number formatting must honor Space locale setting #199126

dolivanu opened this issue Nov 6, 2024 · 2 comments
Labels
Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dolivanu
Copy link

dolivanu commented Nov 6, 2024

Describe the feature:
Numeral formatting in Kibana is done through patterns with the Numeral.js library.

Numeral Formatting

Numeral formatting patterns are used in multiple places in Kibana, including: Canvas

These patterns should take into account the locale defined in each Space:

The display of these patterns is affected by the advanced setting format:number:defaultLocale. The default locale is en, but some examples will specify that they are using an alternate locale.

Canvas number formatting with the numberformat function does not honor the Space locale configuration, formatting always with the default en locale. This issue backs to 2019, stating in 2023 that this disparity between Dashboards (honors Space locale) and Canvas (does not honor Space locale, using always en) would not be fixed, aka Canvas would not honor Space locale setting and would format always with the default en locale.

Canvas does not use Kibana number formatting locale

[Canvas] [Discuss] How should Canvas use formatters?

Feature Request: Canvas should honor the Space locale setting, allowing formatting numbers with different locales like es for Spanish (Spain).

Describe a specific use case for the feature:

If you want to generate a pixel-perfect, paginated report using Kibana, the natural choice is Canvas as stated in the README:

Canvas is one of such applications, in particular catering to users looking for desktop-publishing level of control for the presentation of their data summaries.

Canvas focuses on highly customizable layout more suited to highly curated presentations...

Numeral formatting using locales other than en is required in countries outside the anglosphere when showing numbers with fractional part and/or big enough so the thousands separator is a must for legibility.

For example in the financial sector the monetary amounts normally are displayed with decimal separator and thousands separator. Abbreviations are not suitable in general as the exact number must be displayed.

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 6, 2024
@bhavyarm bhavyarm added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Canvas labels Nov 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 8, 2024
@Heenawter
Copy link
Contributor

We are only prioritizing critical Canvas issues at the moment. Closing for now.

@Heenawter Heenawter closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants