[6.3][CI Failure] dashboard app dashboard queries Pie chart attached to saved search filters data as expected

[tylersmalley]

Consecutive failures.

https://kibana-ci.elastic.co/job/elastic+kibana+6.3+multijob-selenium/177/console
https://kibana-ci.elastic.co/job/elastic+kibana+6.3+multijob-selenium/178/console
https://kibana-ci.elastic.co/job/elastic+kibana+6.3+multijob-selenium/179/console

22:36:58      └- ✖ fail: "dashboard app dashboard queries Pie chart attached to saved search filters data as expected"
22:36:58      │        tryForTime timeout: Error: tryForTime timeout: Error: tryForTime timeout: [POST http://localhost:9515/session/d958fcc6be4b1675e3cad3e019685ff4/element / {"using":"css selector","value":"[group-name=\"buckets\"] vis-editor-agg-params:not(.ng-hide) .agg-select"}] no such element: Unable to locate element: {"method":"css selector","selector":"[group-name="buckets"] vis-editor-agg-params:not(.ng-hide) .agg-select"}
22:36:58      │         (Session info: chrome=66.0.3359.181)
22:36:58      │         (Driver info: chromedriver=2.36.540471 (9c759b81a907e70363c6312294d30b6ccccc2752),platform=Linux 4.4.0-1057-aws x86_64)
22:36:58      │           at Server._post (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/test/functional/services/remote/verbose_remote_logging.js:22:21)
22:36:58      │           at runRequest (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/leadfoot/Session.js:92:40)
22:36:58      │           at /var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/leadfoot/Session.js:113:39
22:36:58      │           at new Promise (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/dojo/Promise.js:172:17)
22:36:58      │           at Session._post (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/leadfoot/Session.js:67:10)
22:36:58      │           at Session.find (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/leadfoot/Session.js:1304:15)
22:36:58      │           at Command.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/leadfoot/Command.js:42:36)
22:36:58      │           at /var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/dojo/Promise.js:156:41
22:36:58      │           at run (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/dojo/Promise.js:51:33)
22:36:58      │           at /var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/dojo/nextTick.js:35:17
22:36:58      │           at _combinedTickCallback (internal/process/next_tick.js:131:7)
22:36:58      │           at process._tickCallback (internal/process/next_tick.js:180:9)
22:36:58      │       
22:36:58      │           at Command.find (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/leadfoot/Command.js:23:10)
22:36:58      │           at Command.prototype.(anonymous function) [as findByCssSelector] (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/leadfoot/lib/strategies.js:29:16)
22:36:58      │           at _ensureElementWithTimeout (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/test/functional/services/find.js:58:29)
22:36:58      │           at retry.try (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/test/functional/services/find.js:38:33)
22:36:58      │           at tryCatcher (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/util.js:26:23)
22:36:58      │           at Function.Promise.attempt.Promise.try (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/method.js:31:24)
22:36:58      │           at attempt (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/test/common/services/retry.js:33:38)
22:36:58      │           at tryCatcher (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/util.js:26:23)
22:36:58      │           at Promise._settlePromiseFromHandler (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:503:31)
22:36:58      │           at Promise._settlePromiseAt (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:577:18)
22:36:58      │           at Promise._settlePromises (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:693:14)
22:36:58      │           at Async._drainQueue (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:123:16)
22:36:58      │           at Async._drainQueues (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:133:10)
22:36:58      │           at Immediate.Async.drainQueues [as _onImmediate] (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:15:14)
22:36:58      │           at runCallback (timers.js:794:20)
22:36:58      │           at tryOnImmediate (timers.js:752:5)
22:36:58      │           at processImmediate [as _immediateCallback] (timers.js:729:5)
22:36:58      │       
22:36:58      │           at attempt (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/test/common/services/retry.js:30:17)
22:36:58      │           at tryCatcher (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/util.js:26:23)
22:36:58      │           at Promise._settlePromiseFromHandler (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:503:31)
22:36:58      │           at Promise._settlePromiseAt (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:577:18)
22:36:58      │           at Promise._settlePromises (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:693:14)
22:36:58      │           at Async._drainQueue (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:123:16)
22:36:58      │           at Async._drainQueues (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:133:10)
22:36:58      │           at Immediate.Async.drainQueues (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:15:14)
22:36:58      │           at runCallback (timers.js:794:20)
22:36:58      │           at tryOnImmediate (timers.js:752:5)
22:36:58      │           at processImmediate [as _immediateCallback] (timers.js:729:5)
22:36:58      │       
22:36:58      │           at attempt (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/test/common/services/retry.js:30:17)
22:36:58      │           at tryCatcher (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/util.js:26:23)
22:36:58      │           at Promise._settlePromiseFromHandler (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:503:31)
22:36:58      │           at Promise._settlePromiseAt (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:577:18)
22:36:58      │           at Promise._settlePromises (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/promise.js:693:14)
22:36:58      │           at Async._drainQueue (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:123:16)
22:36:58      │           at Async._drainQueues (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:133:10)
22:36:58      │           at Immediate.Async.drainQueues (/var/lib/jenkins/workspace/elastic+kibana+6.3+multijob-selenium/kibana/node_modules/bluebird/js/main/async.js:15:14)
22:36:58      │           at runCallback (timers.js:794:20)
22:36:58      │           at tryOnImmediate (timers.js:752:5)
22:36:58      │           at processImmediate [as _immediateCallback] (timers.js:729:5)
22:36:58      │       

@elastic/kibana-sharing

[tylersmalley]

@liza-mae, could this be related to the changes from #19688?

[liza-mae]

@tylersmalley, yes #19688 seems to have exposed this problem the test needs to wait for the page to be loaded.

[liza-mae]

This should fix it, I can do another PR for it, if someone has not already.
In file: test/functional/apps/dashboard/_dashboard_queries.js
In test: 'Pie chart attached to saved search filters data as expected'
await PageObjects.visualize.selectSearch('bytes < 90');
// Liza added waitUntilLoadingHasFinished();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.visualize.clickBucket('Split Slices');

[liza-mae]

Looks like the test has been rewritten in master, so this only impacts 6.3

[stacey-gammon]

Yes that'd be great if you could pull together a PR @liza-mae. Sorry if there was any confusion on the original PR. Going forward, even if you have changes that don't directly cause a failing test, but indirectly cause it to appear consistently (e.g. maybe that PR introduced a tiny timing change), we should really check in the fix as part of the original PR, or as a separate PR, but get it in there first. Otherwise the constant build failures can hold developers up (though luckily this is only 6.3 so it wasn't a big problem).

Apologies if you thought I was on top of that change, I just didn't have time. I very much appreciate you figuring out the issue and how to fix it!!

[liza-mae]

@stacey-gammon yes I will pull the PR for the fix. Sorry I just started running these tests so I am still learning best practices and such. I agree it makes sense to have just put the fix into the original PR, even though it appears to be an indirect failure. I needed my changes merged to test cloud on 6.3 for BC11 today. Will get to this fix shortly, thanks again!

[liza-mae]

Merged #19828, closing.