Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky: Functional testing framework sometimes doesn't navigate #19750

Closed
timroes opened this issue Jun 8, 2018 · 1 comment
Closed

Flaky: Functional testing framework sometimes doesn't navigate #19750

timroes opened this issue Jun 8, 2018 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test Team:QA Team label for QA Team test

Comments

@timroes
Copy link
Contributor

timroes commented Jun 8, 2018

We have found this via the _linked_saved_search test case.

The beginning of the test looks like:

before(async () => {
  await PageObjects.common.navigateToUrl('discover', '');
  await PageObjects.discover.saveSearch(savedSearchName);
});

it('should create a visualization from a saved search', async () => {
  retry.try(async () => {
    // Sometimes navigation to the page fails, so we have this in a retry
    await PageObjects.common.navigateToUrl('visualize', 'new');
    await PageObjects.visualize.waitForVisualizationSelectPage();
  });

This will navigate to discover and save a search. The saveSearch method actually ends with a await testSubjects.exists('saveSearchSuccess', 2000); to wait for the notification to show.

We now had several failures where the first test actually wasn't able to navigate to the visualzie page. Even though it was put in a retry and waiting for the visualize page to be visible, and if not try to navigate to that page again, we ended up in several test cases, that it failed after the maximum retries, and the screenshot showed, that it was still on the Discover page (but the search was saved successfully there, as you can see in the page top menu bar).

I have no idea, what could cause the test framework not to execute that simple navigation properly, since it seems to work in a lot of cases, but the test failures for those on CI were actually rather often, so I think that the navigation has some severe flaws, we need to look into.

@timroes timroes added bug Fixes for quality problems that affect the customer experience test Team:QA Team label for QA Team labels Jun 8, 2018
@cjcenizal cjcenizal changed the title Functional testing framework sometimes doesn't navigate Flaky: Functional testing framework sometimes doesn't navigate Jul 27, 2018
@liza-mae liza-mae added failed-test A test failure on a tracked branch, potentially flaky-test and removed flaky-failing-test labels Nov 1, 2018
@stacey-gammon
Copy link
Contributor

I don't see any more test failures in the last 60 days for "visualization from a saved search", so maybe this is obsolete now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test Team:QA Team label for QA Team test
Projects
None yet
Development

No branches or pull requests

4 participants