Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automatic Import] Cel template fixes #196945

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Oct 18, 2024

Summary

This PR corrects the CEL template so that it can successfully complete package policy installation. The fixes are 1) adding a template path, and 2) removing the common template values from the cel templates.

Tested and verified with and without the CEL generation FF enabled.

@kgeller kgeller added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.16.0 Team:Security-Scalability Team label for Security Integrations Scalability Team backport:version Backport to applied version labels labels Oct 18, 2024
@kgeller kgeller self-assigned this Oct 18, 2024
@kgeller kgeller marked this pull request as ready for review October 18, 2024 20:18
@kgeller kgeller requested a review from a team as a code owner October 18, 2024 20:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @kgeller

@kgeller kgeller merged commit 15390e4 into elastic:main Oct 19, 2024
32 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11418122443

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2024
## Summary

This PR corrects the CEL template so that it can successfully complete
package policy installation. The fixes are 1) adding a template path,
and 2) removing the common template values from the cel templates.

Tested and verified with and without the CEL generation FF enabled.

(cherry picked from commit 15390e4)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security-Scalability Team label for Security Integrations Scalability Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants