[APM][Otel]Fix get_error_group_main_statistics making trace.id optional field #196822
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crespocarlos
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
approved these changes
Oct 18, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
|
Starting backport for target branches: 8.15, 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11412316379 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…al field (elastic#196822) fixes [196821](elastic#196821) ## Summary `trace.id` should've been sent as an optional field to the `get_error_group_main_statistics` query. This PR fixes that <img width="700" alt="image" src="https://github.com/user-attachments/assets/20b63361-9645-418f-a611-2c0e29b385c7"> ## How to test - Run the opentelemetry demo: https://github.com/elastic/opentelemetry-demo/tree/rca_ingress_obs - Navigate to Application > Services - Open the service details for loadgenerator (cherry picked from commit a36fa11)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…al field (elastic#196822) fixes [196821](elastic#196821) ## Summary `trace.id` should've been sent as an optional field to the `get_error_group_main_statistics` query. This PR fixes that <img width="700" alt="image" src="https://github.com/user-attachments/assets/20b63361-9645-418f-a611-2c0e29b385c7"> ## How to test - Run the opentelemetry demo: https://github.com/elastic/opentelemetry-demo/tree/rca_ingress_obs - Navigate to Application > Services - Open the service details for loadgenerator (cherry picked from commit a36fa11)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 19, 2024
… optional field (#196822) (#196966) # Backport This will backport the following commits from `main` to `8.16`: - [[APM][Otel]Fix get_error_group_main_statistics making trace.id optional field (#196822)](#196822) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T23:16:36Z","message":"[APM][Otel]Fix get_error_group_main_statistics making trace.id optional field (#196822)\n\nfixes [196821](https://github.com/elastic/kibana/issues/196821)\r\n\r\n## Summary\r\n\r\n`trace.id` should've been sent as an optional field to the\r\n`get_error_group_main_statistics` query. This PR fixes that\r\n\r\n<img width=\"700\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b63361-9645-418f-a611-2c0e29b385c7\">\r\n\r\n\r\n## How to test \r\n\r\n- Run the opentelemetry demo:\r\nhttps://github.com/elastic/opentelemetry-demo/tree/rca_ingress_obs\r\n- Navigate to Application > Services\r\n- Open the service details for loadgenerator","sha":"a36fa1151b4af7ecd1565bf2b67fad20835b8209","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM][Otel]Fix get_error_group_main_statistics making trace.id optional field","number":196822,"url":"https://github.com/elastic/kibana/pull/196822","mergeCommit":{"message":"[APM][Otel]Fix get_error_group_main_statistics making trace.id optional field (#196822)\n\nfixes [196821](https://github.com/elastic/kibana/issues/196821)\r\n\r\n## Summary\r\n\r\n`trace.id` should've been sent as an optional field to the\r\n`get_error_group_main_statistics` query. This PR fixes that\r\n\r\n<img width=\"700\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b63361-9645-418f-a611-2c0e29b385c7\">\r\n\r\n\r\n## How to test \r\n\r\n- Run the opentelemetry demo:\r\nhttps://github.com/elastic/opentelemetry-demo/tree/rca_ingress_obs\r\n- Navigate to Application > Services\r\n- Open the service details for loadgenerator","sha":"a36fa1151b4af7ecd1565bf2b67fad20835b8209"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196822","number":196822,"mergeCommit":{"message":"[APM][Otel]Fix get_error_group_main_statistics making trace.id optional field (#196822)\n\nfixes [196821](https://github.com/elastic/kibana/issues/196821)\r\n\r\n## Summary\r\n\r\n`trace.id` should've been sent as an optional field to the\r\n`get_error_group_main_statistics` query. This PR fixes that\r\n\r\n<img width=\"700\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/20b63361-9645-418f-a611-2c0e29b385c7\">\r\n\r\n\r\n## How to test \r\n\r\n- Run the opentelemetry demo:\r\nhttps://github.com/elastic/opentelemetry-demo/tree/rca_ingress_obs\r\n- Navigate to Application > Services\r\n- Open the service details for loadgenerator","sha":"a36fa1151b4af7ecd1565bf2b67fad20835b8209"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 196821
Summary
trace.idshould've been sent as an optional field to theget_error_group_main_statisticsquery. This PR fixes thatHow to test