Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] embeddable filters are not displayed #193553

Closed
mbondyra opened this issue Sep 20, 2024 · 4 comments
Closed

[Dashboard] embeddable filters are not displayed #193553

mbondyra opened this issue Sep 20, 2024 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Sep 20, 2024

Kibana version:
main

While working on #186642 we noticed that the filter icon doesn't display correctly for Lens embeddable. After digging more, it looks like the problem appears for all the embeddables.

expected display

Image

actual display (when loaded for the first time)

Image

(For Lens, it works on main because it hasn't been rewritten yet, but looks like the root cause might be the same as for visualize.

As for Maps, it works correctly, but once you click on the options for "maps by reference + filters" map vis, and Edit map, the filter is lost (video documenting it below)

Sep-20-2024.09-54-51.mov

Also, side question - did we remove the 'linked to library' icon (see the expected display) or is this a bug too that it doesn't display? 🤔

To reproduce you can use the SOs from here. Change the extension to .ndjson: filtersbug.json

@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@teresaalvarezsoler
Copy link

Afaik, the Saved to library icon should appear too. I think we will remove it as part of this other PR but it hasn't been merged yet #182535. Can you please confirm @andreadelrio?

@nreese
Copy link
Contributor

nreese commented Sep 20, 2024

Afaik, the Saved to library icon should appear too. I think we will remove it as part of this other PR but it hasn't been merged yet #182535.

Library notification was removed outside of hover actions in #190797.

@nreese
Copy link
Contributor

nreese commented Sep 20, 2024

This issue covers a few items. I am going to close and break items out into separate issues.

Created #193598 for visualize embeddable not displaying filters notification.

Created #193601 for the maps filter badge disappearing.

@nreese nreese closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants