Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObservabilityAIAssistant] Optimize initial load bundles #191601

Closed
Tracked by #191599
tonyghiani opened this issue Aug 28, 2024 · 1 comment · Fixed by #192066
Closed
Tracked by #191599

[ObservabilityAIAssistant] Optimize initial load bundles #191601

tonyghiani opened this issue Aug 28, 2024 · 1 comment · Fixed by #192066
Assignees
Labels
Team:obs-ux-logs Observability Logs User Experience Team

Comments

@tonyghiani
Copy link
Contributor

tonyghiani commented Aug 28, 2024

📓 Summary

Part of #191599

The Observability AI Assistant App plugin loads an icon in the navbar to access the AI assistant. The issue, in this case, is that, even if the icon is not visible for a specific app, the visibility check occurs too late in the react tree, which implies loading all the code used for the AIAssistant control even when this is not visible for the user.

Image

This can be potentially fixed by moving the assertion earlier in the rendering step, and applying correctly the lazy loading on the LazyNavControl component.

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 28, 2024
@jughosta jughosta added the Team:obs-ux-logs Observability Logs User Experience Team label Sep 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants