Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedDataTable] Header row height config doesn't work #188472

Closed
lukasolson opened this issue Jul 16, 2024 · 4 comments
Closed

[UnifiedDataTable] Header row height config doesn't work #188472

lukasolson opened this issue Jul 16, 2024 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:UnifiedDataTable impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@lukasolson
Copy link
Member

Kibana version: 8.13+

Describe the bug:

The "Header row height" configuration in the Discover data grid doesn't appear to work.

Steps to reproduce:

  1. Open Discover
  2. Change the "Header row height"

Nothing appears to change.

Expected behavior:

The header row height changes.

Screenshots (if relevant):

Screen.Recording.2024-07-16.at.10.59.59.AM.mov
@lukasolson lukasolson added bug Fixes for quality problems that affect the customer experience loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week Feature:UnifiedDataTable labels Jul 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee
Copy link
Contributor

@lukasolson The header row height config actually determines the maximum height of the header row instead of an absolute height like the cell row height config (which is admittedly a bit confusing and inconsistent), so I think it will behave as intended if you have a field name that wraps. The EUI team is looking to make the cell row height config also behave as a maximum which should help resolve this inconsistency if all goes well: elastic/eui#7835.

@lukasolson
Copy link
Member Author

Ahh, makes sense. I definitely find it confusing that they are inconsistent, so glad to hear this is being fixed. Maybe we could update the verbiage to reflect that it is the max height.

@kertal
Copy link
Member

kertal commented Jul 17, 2024

the plan is to provide something like this, which is more compact, clearer wording, but we need to first check performance impact, since auto fit height is more expensive.

image

I think we can close this issue, because it works like expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:UnifiedDataTable impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants