Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling Flamegraph not rendering in Iframe #188288

Closed
LucaWintergerst opened this issue Jul 15, 2024 · 8 comments
Closed

Profiling Flamegraph not rendering in Iframe #188288

LucaWintergerst opened this issue Jul 15, 2024 · 8 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Feature:UniversalProfiling Universal Profiling observability feature needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@LucaWintergerst
Copy link
Contributor

Kibana version: 8.14.1

Elasticsearch version: 8.14.1

Describe the bug: The Flamegraph page of the Profiling UI does not load when it's embedded in an Iframe. This is the only page in Kibana that has this behaviour today.

Steps to reproduce:

  1. embed in iframe
  2. go to Flamegraph page

Expected behavior: load page as usual

Screenshots (if relevant):

CleanShot 2024-07-07 at 07 40 43@2x

Errors in browser console (if relevant):

DOMException: Failed to read a named property 'visualViewport' from 'Window': Blocked a frame with origin "https://2fx1em5odso7-qip6hrxwipet.env.play.instruqt.com/" from accessing a cross-origin frame.

Provide logs and/or server output (if relevant):

Any additional context:

@LucaWintergerst LucaWintergerst added bug Fixes for quality problems that affect the customer experience Feature:UniversalProfiling Universal Profiling observability feature labels Jul 15, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 15, 2024
@smith smith added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jul 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 19, 2024
@smith smith added the needs-refinement A reason and acceptance criteria need to be defined for this issue label Jul 19, 2024
@cauemarcondes cauemarcondes self-assigned this Aug 7, 2024
@cauemarcondes
Copy link
Contributor

@LucaWintergerst It looks like this is an elastic-charts issue rather than Profiling itself. I made a test rendering the Flame component with the same mock data inside an iFrame and I got the same error.

Screenshot 2024-08-07 at 16 43 11

I am pulling @nickofthyme and @markov00 from the charts team to get their opinion.

@nickofthyme nickofthyme added Feature:ElasticCharts Issues related to the elastic-charts library Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nickofthyme
Copy link
Contributor

Yeah based on a quick look I think you are right @cauemarcondes. I'll take a closer look this week.

@nickofthyme
Copy link
Contributor

@cauemarcondes could you provide the local reproduction you used?

@cauemarcondes
Copy link
Contributor

I created a repo with two servers, one with the chart and another with the iFrame loading the chart in it. I added you as a collaborator, let me know if it worked.

@nickofthyme
Copy link
Contributor

Awesome, got it. I can see the error now. I'll let you know what I find.

@nickofthyme
Copy link
Contributor

This is fixed in #190313 via elastic/elastic-charts#2502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Feature:UniversalProfiling Universal Profiling observability feature needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants