Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram dashboard hide/show legend throws a TypeError sometimes #18792

Closed
liza-mae opened this issue May 3, 2018 · 11 comments
Closed

Histogram dashboard hide/show legend throws a TypeError sometimes #18792

liza-mae opened this issue May 3, 2018 · 11 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@liza-mae
Copy link
Contributor

liza-mae commented May 3, 2018

Kibana version: 6.3.0 BC2
Elasticsearch version: 6.3.0 BC2

Server OS version: Ubuntu tar

Browser version: Firefox / Chrome Latest

Browser OS version: OSX

Original install method (e.g. download page, yum, from source, etc.):
From staging

Description of the problem including expected versus actual behavior:

Discarding changes in dashboards throws a typeerror and messes up dashboard

Steps to reproduce:

Install Elasticsearch, Kibana
Create a dashboard, histogram
hiding / showing the legend throws an error

screenshot at may 03 15-31-36

@liza-mae liza-mae added Feature:Dashboard Dashboard related features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience triage_needed labels May 3, 2018
@timroes timroes added :Sharing and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels May 9, 2018
@timroes
Copy link
Contributor

timroes commented May 9, 2018

@stacey-gammon I think that looks more like a dashboard issue? I switched labels but please feel free to ping me if I am mistaken. Also this looks like it could be a potential blocker for 6.3.0?

@stacey-gammon
Copy link
Contributor

Yep, looks like a dashboard issue. Investigating now to see if it's a blocker or not. As long as it doesn't kill the whole dashboard, even if the collapsed state of the legend isn't being saved, I think it's worthy to go into 6.3.1 but not a blocker.

@stacey-gammon
Copy link
Contributor

I can't repro (at least on BC3 but nothing changed in dashboard from BC2 to BC3 that should have created this).

I'm opening/closing the histogram legend on the metricbeats dashboard and everything works.

@liza-mae - does it happen all the time for you?

@liza-mae
Copy link
Contributor Author

liza-mae commented May 9, 2018

ok - let me check it again and see

@liza-mae liza-mae changed the title Histogram hide/show legend throws a TypeError sometimes Histogram hide/show legend on dashboard throws a TypeError sometimes May 9, 2018
@liza-mae
Copy link
Contributor Author

liza-mae commented May 9, 2018

I have added another issue #18959 which shows when just isolated to the visualization, it throws two different TypeErrors.

As far as this issue it does not occur all the time, but when it does occur I do recall it stays in that state and is reproducible. I was not able to reproduce the exact error this time, but was able to catch the same error again which I notice only in dashboards, but this time it did not mess up the histogram. In dashboard: I see TypeError: Cannot convert undefined or null to object.

screenshot at may 09 11-13-59

@stacey-gammon
Copy link
Contributor

Can you walk me through what you are doing before you hit it? Just opening/closing the legend a bunch of times? Or do you have to open/close other dashboards, do anything else on the page?

I'll keep trying to repro on my end...

@liza-mae
Copy link
Contributor Author

liza-mae commented May 9, 2018

When the error occurred for me the first time, I just open/close the legend one time and saw the error. Once it was in that state it would continue to mess up even after I did a refresh to fix it.

Today when I went back to reproduce I did open/close a few times and only saw the error but it did not cause the histogram to mess up as it did the first time.

I am still on BC2 but I will also continue to try reproduce.

@liza-mae
Copy link
Contributor Author

liza-mae commented May 9, 2018

Sorry missed answering your other question, no other dashboards or browsers were open at the time, just metricbeat system one.

@liza-mae liza-mae changed the title Histogram hide/show legend on dashboard throws a TypeError sometimes Histogram dashboard hide/show legend throws a TypeError sometimes May 9, 2018
@stacey-gammon
Copy link
Contributor

@liza-mae - Are you still able to easily reproduce? Can you trigger it with a simple bar chart histogram or only the metric beat one? Have you seen any more instances of it messing up a dashboard or only the console error?

If so, next time you run into it if we can zoom I can maybe look at the code in browser tools and see what the issue is.

@liza-mae
Copy link
Contributor Author

@stacey-gammon I tried on BC6 was not able to get the dashboard to mess up on rendering, but I can still reproduce the TypeError in the console.

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 14, 2018
@markov00
Copy link
Member

Closing this issue due to inactivity.

We are trying to keep our issues to a manageable amount, which means we are trying to close issues we cannot reproduce or gather required information for some time. Please feel free to still provide the requested information in case the issue still persists on an up-to-date Kibana version. We will gladly reopen this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants