Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Aborted requests causes notification toasts to display #187839

Closed
sorenlouv opened this issue Jul 9, 2024 · 1 comment
Closed

[Obs AI Assistant] Aborted requests causes notification toasts to display #187839

sorenlouv opened this issue Jul 9, 2024 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Obs AI Assistant Observability AI Assistant

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Jul 9, 2024 •
edited
Loading

If a user asks a question, and don't want to wait for the LLM to respond, they can click "Stop generating". This stops the generation by aborting the request but it also causes an error toast to be displayed. This is noisy and not the intention.

Solution
We should not show toasts for aborted requests (at least not user-invoked abort events).

Kapture 2024-07-09 at 11 15 57
@sorenlouv sorenlouv added bug Fixes for quality problems that affect the customer experience Team:Obs AI Assistant Observability AI Assistant labels Jul 9, 2024
@grabowskit
Copy link

This is duplicate of #186794

@emma-raffenne emma-raffenne closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sorenlouv @grabowskit @emma-raffenne