Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] OR instead of AND when searching saved searches, visualizations, and dashboards #18649

Closed
anhlqn opened this issue Apr 28, 2018 · 9 comments

Comments

@anhlqn
Copy link
Contributor

anhlqn commented Apr 28, 2018

Kibana version: 5.6.8

Elasticsearch version: 5.6.8

Server OS version: Windows Server 2012 R2

Browser version: Chrome 63

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.): Zip file

Description of the problem including expected versus actual behavior:
2018-04-27 18_25_31-kibana

I guess the screenshot explains the issue pretty well. When I search for a saved item in Kibana, i.e., searches, visualizations, dashboards, Kibana displays any items that match any of the search terms, which makes it a nightmare to search through 400 visualizations and tens of dashboards.

Searching for perfmon disk should return only visualizations that have both perfmon AND disk in their name, not perfmon OR disk.

This is not the behavior in Kibana 4, so I wonder what the justification for this change is or whether it's just a bug. I'm surprised that this change is still around in Kibana 5.6.8 without anyone complaining.

Steps to reproduce:

  1. Open the search box for saved searches, visualizations, or dashboards
  2. Enter two search terms
@chrisronline
Copy link
Contributor

Hi @anhlqn,

Can you try putting the search query in quotes, like "perfmon disk"?

Does that help?

@anhlqn
Copy link
Contributor Author

anhlqn commented Apr 30, 2018

Yes, "perfmon disk" works. Looks like it behaves like a normal query with OR as the default operator?

@chrisronline
Copy link
Contributor

Correct. See this code and these docs

@anhlqn
Copy link
Contributor Author

anhlqn commented Apr 30, 2018

Would that make sense in terms of user experience though? This is the management UI, not the regular search box. When I type in perfmon disk, I think naturally I am looking for both perfmon and disk visualizations, not perfmon or disk.

@chrisronline
Copy link
Contributor

I don't disagree, but the experience throughout Kibana is consistent with the OR. If we did decide to change, we'd want to ensure all other areas change as well.

Pinging for thoughts: @elastic/kibana-visualizations @elastic/kibana-sharing

@anhlqn
Copy link
Contributor Author

anhlqn commented May 1, 2018

Thanks for the clarification.

@trevan
Copy link
Contributor

trevan commented May 1, 2018

This is probably related or a duplicate of #14687.

@anhlqn
Copy link
Contributor Author

anhlqn commented May 2, 2018

@trevan yes, it's duplicate of #14687.

@LeeDr
Copy link

LeeDr commented Aug 10, 2018

I'm going to close this so I don't have to update 2 issues. See #14687

@LeeDr LeeDr closed this as completed Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants