Only include scripted fields if really needed in request

[bczifra]

Kibana version: 6.2.3

Elasticsearch version: 6.2.3

Server OS version: OSX

Browser version: Chrome

Browser OS version: 65.0.3325.181 (Official Build) (64-bit)

Original install method (e.g. download page, yum, from source, etc.): tar

Description of the problem including expected versus actual behavior: If an index pattern has a scripted field associated with it, then any Kibana requests related to that index pattern (visualizations, dashboards, etc.) will include that scripted field as part of the request, even if the request does not require the scripted field.

Steps to reproduce:

1. Create a scripted field associated with an index pattern.
2. Create a simple visualization based on that index pattern that doesn't referenced the scripted field in any way.
3. Render the visualization.
4. Check the Chrome "Network" toolbar and the scripted field will show up as part of the request.

[Bargs]

Are you seeing any issues as a result? Since the visualization request is asking for 0 hits, I would assume the script isn't actually being run at all.

[bczifra]

No, no issues, just didn't expect it to be part of the request.

[Bargs]

Gotcha. In that case I'd only really want to exclude it if it doesn't overly complicate the code. I'll leave this open as a chore task.

[rayafratkina]

Per recent report, this is actually causing issues, so removing Chore label and reclassifying as bug.
Note from a user: "Many visualizations return shard fails due to amount of script that elastic has to compile which is limited (configurable). "

[alexfrancoeur]

I believe the Elasticsearch team is discussing some of this on their end as well - elastic/elasticsearch#31824

[AlonaNadler]

Elasticsearch merged a fix for this elastic/elasticsearch#31824
Can we close this issue?

@elastic/kibana-app

[timroes]

Yeah since the Elasticsearch team no longer calculates scripted fields in case we send size=0 from 6.5.0 onwards there is no need for us to strip these of in the Kibana side.