Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Make existing OpenAPI specs for Endpoint management API documentation-ready #183817

Closed
1 of 26 tasks
maximpn opened this issue May 20, 2024 · 3 comments
Closed
1 of 26 tasks
Labels
8.16 candidate docs grooming Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@maximpn
Copy link
Contributor

maximpn commented May 20, 2024

Epic: https://github.com/elastic/security-team/issues/9525
Depends on: #183815, #183816

Deadline: Sep 24, 2024 (see milestones in https://github.com/elastic/security-team/issues/9400)

Summary

As part of the Serverless project, we need to make sure OpenAPI specs for all public Endpoint management API endpoints are polished and ready to be published on a documentation website. Please look for more context in the epic, and please find below what needs to be done exactly.

API endpoints

The following public API endpoints were discovered during research:

  • GET /api/endpoint/metadata
  • GET /api/endpoint/metadata/{id}
  • GET /api/endpoint/metadata/transforms
  • POST /api/endpoint/suggestions/{suggestion_type}
  • GET /api/endpoint/policy_response
  • GET /api/endpoint/policy/summaries
  • GET /api/endpoint/action_status
  • GET /api/endpoint/action/state
  • GET /api/endpoint/action_log/{agent_id}
  • GET /api/endpoint/action
  • GET /api/endpoint/action/{action_id}
  • POST /api/endpoint/action/isolate
  • POST /api/endpoint/action/unisolate
  • POST /api/endpoint/action/kill_process
  • POST /api/endpoint/action/suspend_process
  • POST /api/endpoint/action/running_procs
  • POST /api/endpoint/action/get_file
  • POST /api/endpoint/action/execute
  • POST /api/endpoint/action/upload
  • GET /api/endpoint/action/{action_id}/file/{file_id}/download
  • GET /api/endpoint/action/{action_id}/file/{file_id}
  • POST /api/endpoint/protection_updates_note/{package_policy_id}
  • GET /api/endpoint/protection_updates_note/{package_policy_id}
  • POST /api/endpoint/isolate
  • POST /api/endpoint/unisolate

Note that two of the above endpoints are marked as deprecated in the code base and should be considered to be available only in ESS:

  • POST /api/endpoint/isolate
  • POST /api/endpoint/unisolate

To do

For all the Endpoint management API endpoints (including those above), in the corresponding OpenAPI specification files, please:

  • Add summaries for:
    • API endpoints
    • HTTP methods
  • Add descriptions for:
    • API endpoints
    • HTTP methods
    • endpoint's parameters
    • requests
    • responses
    • shared schemas
  • Add examples.
  • Add tags to group your endpoints in the docs (depends on: [Security Solution] Bundle root level tags  #183375)
  • Make sure the generated API reference documentation looks nice and correct on bump.sh.
  • Make sure the generated Serverless API reference documentation doesn't contain available only in ESS API endpoints.

Ask @maximpn to provide you with an example of a polished and documentation-ready OpenAPI spec. Please also ask @maximpn for a link to the generated API reference documentation (at the time of creating this ticket, it didn't exist).

@maximpn maximpn added docs Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Project:Serverless Work as part of the Serverless project for its initial release 8.16 candidate labels May 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@banderror banderror removed the Project:Serverless Work as part of the Serverless project for its initial release label Jun 4, 2024
@banderror
Copy link
Contributor

I'm closing this ticket since the Endpoint management API docs have become available on elastic.co/docs/api/doc/serverless and elastic.co/docs/api/doc/kibana. Please open new tickets if any follow-up work is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.16 candidate docs grooming Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

4 participants