Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] report all accepted types during parameter validation #183683

Closed
drewdaemon opened this issue May 16, 2024 · 3 comments
Closed

[ES|QL] report all accepted types during parameter validation #183683

drewdaemon opened this issue May 16, 2024 · 3 comments
Labels
Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@drewdaemon
Copy link
Contributor

Describe the feature:

We only report one type possibility in arg-type validation error messages even if more than one type is acceptable.

For example, Argument of [st_y] must be [cartesian_point], found value ["a"] type [string]

Screenshot 2024-05-16 at 2 33 21 PM

But, actually, st_y accepts a parameter of type cartesian_point or geo_point.

Instead, it would be better to report all accepted types:

Argument of [st_y] must be [cartesian_point, geo_point], found value ["a"] type [string]

@drewdaemon drewdaemon added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels May 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon
Copy link
Contributor Author

I went with impact:medium because I could see this being confusing. Feel free to adjust, @stratoula!

@drewdaemon
Copy link
Contributor Author

Closing in favor of the more comprehensive issue: #180518

@drewdaemon drewdaemon closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

No branches or pull requests

2 participants